Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements Data_File after test campaign #45

Open
TOP-PHE opened this issue Dec 12, 2024 · 0 comments
Open

Enhancements Data_File after test campaign #45

TOP-PHE opened this issue Dec 12, 2024 · 0 comments

Comments

@TOP-PHE
Copy link
Collaborator

TOP-PHE commented Dec 12, 2024

Testing the last delivery, I found tht some improvments and bugs can be tackled:

  1. Logging information: It is necessary to have way to configure the logging level in the data_file like, FULL (like today but 10mm before finshing when more than 10 offers to display...) MEDIUM (only loging main infos like steps passed, nbr of offers but not their details, MINIMUM 5i do not know what would be the minimum...t be discussed)
  2. DATA_File parameters naming convention must be aligned with tehhe OSDM specs, like passenger.reference in data file while externalRef in OSDM spec...
  3. configuration with minimum set of info. If I am using only the foillowing for the trip requirements
    {
    "origin": "urn:uic:stn:8814001",
    "destination": "urn:uic:stn:8892007",
    "startDatetime": "2025-01-15T11:00:00"
    }
    Got the foillowing error :
    {type: "Error", name: "TypeError", message: "Cannot read properties of undefined (reading 'replace')"}
  4. Passenger : External reference. I do not know why I set the external ref of the PAX in the data_file, does not seems to be used... as an external ref is generated automatically in the code.
  5. Empty parameters: If a parameter is empty in the data file, it is anyway used to built the offer call. SHould not we check if the parameter is empty before using it, no added value to send empty parameters in the request
    {"objectType":"StopPlaceRef","stopPlaceRef":"urn:uic:stn:8892007"},"parameters":{"dataFilter":{"carrierFilter":null,"vehicleFilter":{"vehicleNumbers":[null],"lineNumbers":null,"exclude":false}}}},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant