Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation warnings on shaders from VFX graphs #7893

Open
wants to merge 2 commits into
base: 2022.2/staging
Choose a base branch
from

Conversation

ChudeRonczki
Copy link

@ChudeRonczki ChudeRonczki commented May 18, 2023

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Due to formatting issue, any compilation of a VFX Graph, when using URP, causes a spam of irritating warnings.

Testing status

Describe what manual/automated tests were performed for this PR

Recompiled a few VFX Graphs with this version, resulting in a correct behavior and no warnings.

Comments to reviewers

Notes for the reviewers you have assigned.

This isn't an invasive change in any capacity, but it should be a big QOL improvement. It can easily also be made on your side, bypassing this PR. Also, I failed to find clear instructions how to fill some points on the checklist above.

@ChudeRonczki ChudeRonczki marked this pull request as ready for review May 18, 2023 13:46
@ChudeRonczki ChudeRonczki requested a review from a team as a code owner May 18, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant