From e1346ac0684e1b67d19bd230d33218d3807de72d Mon Sep 17 00:00:00 2001 From: Johnathan Butler Date: Mon, 17 Nov 2025 15:50:22 -0800 Subject: [PATCH 1/5] [#PPS-3931] --- impression.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impression.go b/impression.go index c0d1c66..8e1747f 100644 --- a/impression.go +++ b/impression.go @@ -26,7 +26,7 @@ type Impression struct { DisplayManager string `json:"displaymanager,omitempty"` // Name of ad mediation partner, SDK technology, etc DisplayManagerVer string `json:"displaymanagerver,omitempty"` // Version of the above Clickbrowser int `json:"clickbrowser"` // Indicates the type of browser opened upon clicking the creative in an app, where 0 = embedded, 1 = native - Instl int `json:"instl,omitempty"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else) + Instl int `json:"instl"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else) TagID string `json:"tagid,omitempty"` // IDentifier for specific ad placement or ad tag BidFloor float64 `json:"bidfloor,omitempty"` // Bid floor for this impression in CPM BidFloorCurrency string `json:"bidfloorcur,omitempty"` // Currency of bid floor From aa91c41b68320aab9bffe28a0dc411e5d75fa679 Mon Sep 17 00:00:00 2001 From: Johnathan Butler Date: Tue, 18 Nov 2025 10:22:18 -0800 Subject: [PATCH 2/5] [#ABT-3931] Remove omitempty from ambiguous regs.gdpr, imp.instl (kind of) --- impression.go | 2 +- openrtb.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/impression.go b/impression.go index 8e1747f..c0d1c66 100644 --- a/impression.go +++ b/impression.go @@ -26,7 +26,7 @@ type Impression struct { DisplayManager string `json:"displaymanager,omitempty"` // Name of ad mediation partner, SDK technology, etc DisplayManagerVer string `json:"displaymanagerver,omitempty"` // Version of the above Clickbrowser int `json:"clickbrowser"` // Indicates the type of browser opened upon clicking the creative in an app, where 0 = embedded, 1 = native - Instl int `json:"instl"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else) + Instl int `json:"instl,omitempty"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else) TagID string `json:"tagid,omitempty"` // IDentifier for specific ad placement or ad tag BidFloor float64 `json:"bidfloor,omitempty"` // Bid floor for this impression in CPM BidFloorCurrency string `json:"bidfloorcur,omitempty"` // Currency of bid floor diff --git a/openrtb.go b/openrtb.go index ed67aac..d50401c 100644 --- a/openrtb.go +++ b/openrtb.go @@ -774,7 +774,7 @@ type UID struct { // regulations for the United States Children's Online Privacy Protection Act ("COPPA"). type Regulations struct { Coppa int `json:"coppa,omitempty"` // Flag indicating if this request is subject to the COPPA regulations established by the USA FTC, where 0 = no, 1 = yes. - GDPR int `json:"gdpr,omitempty"` // Flag that indicates whether or not the request is subject to GDPR regulations 0 = No, 1 = Yes, omission indicates Unknown. + GDPR int `json:"gdpr"` // Flag that indicates whether or not the request is subject to GDPR regulations 0 = No, 1 = Yes, omission indicates Unknown. USPrivacy string `json:"us_privacy,omitempty"` // Communicates signals regarding consumer privacy under US privacy regulation. Ext RegExtension `json:"ext,omitempty"` } From 0b0d95dfeb67a568c8586f07c5d831ea21046541 Mon Sep 17 00:00:00 2001 From: Johnathan Butler Date: Tue, 18 Nov 2025 10:36:42 -0800 Subject: [PATCH 3/5] [#PPS-3931] possible instl explicit 0 --- impression.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/impression.go b/impression.go index c0d1c66..8e1747f 100644 --- a/impression.go +++ b/impression.go @@ -26,7 +26,7 @@ type Impression struct { DisplayManager string `json:"displaymanager,omitempty"` // Name of ad mediation partner, SDK technology, etc DisplayManagerVer string `json:"displaymanagerver,omitempty"` // Version of the above Clickbrowser int `json:"clickbrowser"` // Indicates the type of browser opened upon clicking the creative in an app, where 0 = embedded, 1 = native - Instl int `json:"instl,omitempty"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else) + Instl int `json:"instl"` // Interstitial, Default: 0 ("1": Interstitial, "0": Something else) TagID string `json:"tagid,omitempty"` // IDentifier for specific ad placement or ad tag BidFloor float64 `json:"bidfloor,omitempty"` // Bid floor for this impression in CPM BidFloorCurrency string `json:"bidfloorcur,omitempty"` // Currency of bid floor From 40a9cf66ed2862afd70b6fa32530e4929f9454d3 Mon Sep 17 00:00:00 2001 From: Johnathan Butler Date: Tue, 18 Nov 2025 13:43:32 -0800 Subject: [PATCH 4/5] [#PPS-3931] regs gdpr nilability, instl test --- bidrequest_test.go | 1 + openrtb.go | 2 +- testdata/breq.banner.json | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/bidrequest_test.go b/bidrequest_test.go index 59419fb..abaf423 100644 --- a/bidrequest_test.go +++ b/bidrequest_test.go @@ -22,6 +22,7 @@ func TestBidRequest(t *testing.T) { ID: "1", Secure: 1, Banner: &Banner{W: 300, H: 250, Pos: AdPosAboveFold, BAttr: []int{CreativeAttributeUserInitiated}}, + Instl: 0, }, }, Site: &Site{ diff --git a/openrtb.go b/openrtb.go index d50401c..53032de 100644 --- a/openrtb.go +++ b/openrtb.go @@ -774,7 +774,7 @@ type UID struct { // regulations for the United States Children's Online Privacy Protection Act ("COPPA"). type Regulations struct { Coppa int `json:"coppa,omitempty"` // Flag indicating if this request is subject to the COPPA regulations established by the USA FTC, where 0 = no, 1 = yes. - GDPR int `json:"gdpr"` // Flag that indicates whether or not the request is subject to GDPR regulations 0 = No, 1 = Yes, omission indicates Unknown. + GDPR *int `json:"gdpr,omitempty"` // Flag that indicates whether the request is subject to GDPR regulations 0 = No, 1 = Yes, omission indicates Unknown. USPrivacy string `json:"us_privacy,omitempty"` // Communicates signals regarding consumer privacy under US privacy regulation. Ext RegExtension `json:"ext,omitempty"` } diff --git a/testdata/breq.banner.json b/testdata/breq.banner.json index 41b34ca..5e6bc14 100644 --- a/testdata/breq.banner.json +++ b/testdata/breq.banner.json @@ -6,6 +6,7 @@ { "id": "1", "secure": 1, + "instl": 0, "banner": { "w": 300, "h": 250, From af22db45d16dbfaabccf4df92b3fc7053f7092b7 Mon Sep 17 00:00:00 2001 From: Johnathan Butler Date: Tue, 18 Nov 2025 13:50:09 -0800 Subject: [PATCH 5/5] [#PPS-3931] test only covers decode. encode behavior was changed --- bidrequest_test.go | 1 - testdata/breq.banner.json | 1 - 2 files changed, 2 deletions(-) diff --git a/bidrequest_test.go b/bidrequest_test.go index abaf423..59419fb 100644 --- a/bidrequest_test.go +++ b/bidrequest_test.go @@ -22,7 +22,6 @@ func TestBidRequest(t *testing.T) { ID: "1", Secure: 1, Banner: &Banner{W: 300, H: 250, Pos: AdPosAboveFold, BAttr: []int{CreativeAttributeUserInitiated}}, - Instl: 0, }, }, Site: &Site{ diff --git a/testdata/breq.banner.json b/testdata/breq.banner.json index 5e6bc14..41b34ca 100644 --- a/testdata/breq.banner.json +++ b/testdata/breq.banner.json @@ -6,7 +6,6 @@ { "id": "1", "secure": 1, - "instl": 0, "banner": { "w": 300, "h": 250,