Skip to content

Regular expressions in the new version of the grammar are wrong #64

@jmhorcas

Description

@jmhorcas

There some mistakes in the new Pull Request ("Breaking Changes") with respect to the regular expressions of the grammar.

For example, the new regular expression for FLOAT and INTEGER is as follows:

FLOAT: '-'? [0-9]* [.][0-9]+;
INTEGER: '0' | '-'? [1-9][0-9]*;

This includes spaces between the number!!!!! The previous grammar was correct:

FLOAT: '-'?[0-9]*[.][0-9]+;
INTEGER: '0' | '-'?[1-9][0-9]*;

This is just an example, but all the expressions should be revised!!!

Another important change in the grammar is the removing of the "constraint" keyword for constraintAttribute. I agree that we should unify to a unique keyword "constraints" for constraint attributes (as in the new grammar) but these changes in the grammar must be officially advertised, since there are a lot of models that now are broken! (e.g., this dataset)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions