Skip to content

chore: ignore checking bricks-software links #9675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2025

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Apr 1, 2025

Links are sometimes used in ADRs like

[traffic-data-service in enterprise](https://github.com/bricks-software/unleash-enterprise/blob/293304a5d67231d584c3fa4c28589af23fb395e3/src/traffic-data/traffic-data-usage-service.ts#L69)

Maybe we should not have links to private repositories in our docs and this check would prevent those, but inside ADRs maybe it's not that important.

Fixes #9632

Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview Apr 22, 2025 2:21pm

Copy link
Contributor

github-actions bot commented Apr 1, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@gastonfournier gastonfournier moved this from New to In Progress in Issues and PRs Apr 2, 2025
@gastonfournier gastonfournier enabled auto-merge (squash) April 2, 2025 14:57
Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍

@github-project-automation github-project-automation bot moved this from In Progress to Approved PRs in Issues and PRs Apr 22, 2025
@gastonfournier gastonfournier merged commit b1fc4d6 into main Apr 22, 2025
11 checks passed
@gastonfournier gastonfournier deleted the gastonfournier-patch-1 branch April 22, 2025 14:25
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in Issues and PRs Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

docs: Broken links found
2 participants