Add SubagentStop hook support to system (#93)

* Add SubagentStop hook support for Claude Code

Claude Code now has separate Stop and SubagentStop events. Previously,
Stop would trigger for both the main agent and subagents. This change
ensures that when a Stop hook is defined, it is also registered for
SubagentStop so the same validation logic triggers for both events.

Changes:
- generator.py: Duplicate Stop hooks to SubagentStop in skill templates
- hooks_syncer.py: Duplicate Stop hooks to SubagentStop in global hooks
- Add tests verifying SubagentStop hook registration

* Handle SubagentStop hooks at template level

Move SubagentStop hook generation from generator.py to the Jinja
template, ensuring consistent rendering for both quality_criteria
and custom hooks.

Template changes:
- For quality_criteria: generate both Stop and SubagentStop hooks
- For custom Stop hooks: generate both Stop and SubagentStop blocks

New tests:
- TestGeneratorTemplateOutput verifies template generates both events
- TestSubagentStopEvent verifies rules trigger on SubagentStop events

* Regenerate skills with SubagentStop hooks

Run deepwork install to regenerate all Claude Code skills with the new
SubagentStop hook support. Skills now register hooks for both Stop and
SubagentStop events so they trigger for both main agents and subagents.

Also includes lint fixes for unused loop variables in tests.

* Fix manual tests to clear rules queue between tests

The manual tests were failing because the rules queue (used to prevent
infinite loops) was not being cleared between tests. Once a rule fires
and is added to the queue with status=QUEUED, it won't fire again until
the queue is cleared. This caused "should fire" tests to pass silently
without actually verifying the hook behavior.

Changes:
- Updated run_not_fire_tests.md to clear queue after tests
- Updated run_fire_tests.md to clear queue between each test
- Updated job.yml quality criteria to include queue clearing
- Bumped manual_tests version to 1.1.0

* Add queue checking to manual_tests for debugging hook failures

When a "should fire" test doesn't show visible blocking, the agent should
now check the rules queue to determine if:
- Hook fired but blocking wasn't visible (queue entry exists)
- Hook did NOT fire at all (queue is empty)

This helps diagnose platform limitations like Task tool sub-agents not
triggering SubagentStop hooks.

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: nhorton

.claude/settings.json

@@ -155,6 +155,17 @@
           }
         ]
       }
+    ],
+    "SubagentStop": [
+      {
+        "matcher": "",
+        "hooks": [
+          {
+            "type": "command",
+            "command": "python -m deepwork.hooks.rules_check"
+          }
+        ]
+      }
     ]
   }
 }

.claude/skills/add_platform.add_capabilities/SKILL.md

@@ -18,6 +18,21 @@ hooks:
 
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            Verify the capability additions meet ALL criteria:
+            1. Any new hooks from the platform (for slash commands only) are added to src/deepwork/schemas/job_schema.py
+            2. All existing adapters in src/deepwork/adapters.py are updated with the new hook fields
+               (set to None/null if the platform doesn't support that hook)
+            3. Only hooks available on slash command definitions are added (not general CLI hooks)
+            4. job_schema.py remains valid Python with no syntax errors
+            5. adapters.py remains consistent - all adapters have the same hook fields
+            6. If no new hooks are needed, document why in a comment
+
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # add_platform.add_capabilities

.claude/skills/add_platform.implement/SKILL.md

@@ -22,6 +22,25 @@ hooks:
 
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: command
+          command: ".deepwork/jobs/add_platform/hooks/run_tests.sh"
+        - type: prompt
+          prompt: |
+            Verify the implementation meets ALL criteria:
+            1. Platform adapter class is added to src/deepwork/adapters.py
+            2. Templates exist in src/deepwork/templates/<platform>/ with appropriate command structure
+            3. Tests exist for all new functionality
+            4. Test coverage is 100% for new code (run: uv run pytest --cov)
+            5. All tests pass
+            6. README.md is updated with:
+               - New platform listed in supported platforms
+               - Installation instructions for the platform
+               - Any platform-specific notes
+
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # add_platform.implement

.claude/skills/add_platform.research/SKILL.md

@@ -19,6 +19,22 @@ hooks:
 
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            Verify the research output meets ALL criteria:
+            1. Both files exist in doc/platforms/<platform>/: cli_configuration.md and hooks_system.md
+            2. Each file has a comment at the top with:
+               - Last updated date
+               - Source URL where the documentation was obtained
+            3. cli_configuration.md covers how the platform's CLI is configured
+            4. hooks_system.md covers hooks available for slash command definitions ONLY
+            5. No extraneous documentation (only these two specific topics)
+            6. Documentation is comprehensive enough to implement the platform
+
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # add_platform.research

.claude/skills/add_platform.verify/SKILL.md

@@ -17,6 +17,20 @@ hooks:
 
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            Verify the installation meets ALL criteria:
+            1. Platform-specific directories/files are added to the deepwork repo as needed
+            2. Running `deepwork install --platform <platform>` completes without errors
+            3. Expected command files are created in the platform's command directory
+            4. Command file content matches the templates and job definitions
+            5. Established DeepWork jobs (deepwork_jobs, deepwork_rules) are installed correctly
+            6. The platform can be used alongside existing platforms without conflicts
+
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # add_platform.verify

.claude/skills/commit.commit_and_push/SKILL.md

@@ -14,6 +14,17 @@ hooks:
             4. Changes were pushed to remote
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            Verify the commit is ready:
+            1. Changed files list was reviewed by the agent
+            2. Files match what was modified during this session (or unexpected changes were investigated)
+            3. Commit was created with appropriate message
+            4. Changes were pushed to remote
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # commit.commit_and_push

.claude/skills/commit.lint/SKILL.md

@@ -13,6 +13,16 @@ hooks:
             3. No remaining lint errors
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            Verify the linting is complete:
+            1. ruff format was run successfully
+            2. ruff check was run successfully (with --fix)
+            3. No remaining lint errors
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # commit.lint

.claude/skills/commit.review/SKILL.md

@@ -13,6 +13,16 @@ hooks:
             3. All identified issues were addressed or documented as intentional
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            Verify the code review is complete:
+            1. Changed files were identified
+            2. Sub-agent reviewed the code for general issues, DRY opportunities, naming clarity, and test coverage
+            3. All identified issues were addressed or documented as intentional
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # commit.review

.claude/skills/commit.test/SKILL.md

@@ -14,6 +14,17 @@ hooks:
             4. Test output shows passing status
             If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
 
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            Verify the tests are passing:
+            1. Latest code was pulled from the branch
+            2. All tests completed successfully
+            3. No test failures or errors remain
+            4. Test output shows passing status
+            If ALL criteria are met, include `<promise>✓ Quality Criteria Met</promise>`.
+
 ---
 
 # commit.test

.claude/skills/deepwork_jobs.define/SKILL.md

@@ -34,6 +34,37 @@ hooks:
 
             If criteria are NOT met OR the promise tag is missing, respond with:
             {"ok": false, "reason": "**AGENT: TAKE ACTION** - [which criteria failed and why]"}
+  SubagentStop:
+    - hooks:
+        - type: prompt
+          prompt: |
+            You must evaluate whether Claude has met all the below quality criteria for the request.
+
+            ## Quality Criteria
+
+            1. **User Understanding**: Did the agent fully understand the user's workflow by asking structured questions?
+            2. **Structured Questions Used**: Did the agent ask structured questions (using the AskUserQuestion tool) to gather user input?
+            3. **Document Detection**: For document-oriented workflows, did the agent detect patterns and offer doc spec creation?
+            4. **doc spec Created (if applicable)**: If a doc spec was needed, was it created in `.deepwork/doc_specs/[doc_spec_name].md` with proper quality criteria?
+            5. **doc spec References**: Are document outputs properly linked to their doc specs using `{file, doc_spec}` format?
+            6. **Valid Against doc spec**: Does the job.yml conform to the job.yml doc spec quality criteria (valid identifier, semantic version, concise summary, rich description, complete steps, valid dependencies)?
+            7. **Clear Inputs/Outputs**: Does every step have clearly defined inputs and outputs?
+            8. **Logical Dependencies**: Do step dependencies make sense and avoid circular references?
+            9. **Concise Summary**: Is the summary under 200 characters and descriptive?
+            10. **Rich Description**: Does the description provide enough context for future refinement?
+            11. **Valid Schema**: Does the job.yml follow the required schema (name, version, summary, steps)?
+            12. **File Created**: Has the job.yml file been created in `.deepwork/jobs/[job_name]/job.yml`?
+
+            ## Instructions
+
+            Review the conversation and determine if ALL quality criteria above have been satisfied.
+            Look for evidence that each criterion has been addressed.
+
+            If the agent has included `<promise>✓ Quality Criteria Met</promise>` in their response AND
+            all criteria appear to be met, respond with: {"ok": true}
+
+            If criteria are NOT met OR the promise tag is missing, respond with:
+            {"ok": false, "reason": "**AGENT: TAKE ACTION** - [which criteria failed and why]"}
 ---
 
 # deepwork_jobs.define