Add early termination on 2 test failures to manual_tests job#116
Merged
Add early termination on 2 test failures to manual_tests job#116
Conversation
- Process now halts as soon as 2 tests have failed and reports results - Each step must revert files and clear queue after completion (mandatory) - Updated quality criteria to reflect these requirements - Bumped version to 1.2.0
The rules_check hook uses `git add -A` to stage files for change detection. The previous `git checkout -- manual_tests/` only reverted the working tree but left files staged in the index, causing cross-contamination between tests. Fix: Use `git reset HEAD manual_tests/ && git checkout -- manual_tests/` to properly unstage and revert all changes.
Auto-generated skill files updated by deepwork install to reflect v1.2.1 changes (early termination on 2 failures, complete git revert).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the manual_tests job to implement early termination when 2 test failures occur, improving efficiency and reducing unnecessary test execution. Also emphasized that file revert and queue clearing are mandatory after each test step.
Key Changes
git checkout -- manual_tests/andrm -rf .deepwork/tmp/rules/queue/*.jsonmust run after each test (or after early termination)Implementation Details
The early termination feature allows the job to fail fast when 2 tests have failed, reducing execution time and providing faster feedback. The cleanup commands (git revert and queue clear) are now explicitly marked as mandatory and must execute regardless of test outcomes to prevent cross-contamination between test runs.