diff --git a/src/deepwork/standard_jobs/deepwork_jobs/job.yml b/src/deepwork/standard_jobs/deepwork_jobs/job.yml index 1c7062c8..8bb58a70 100644 --- a/src/deepwork/standard_jobs/deepwork_jobs/job.yml +++ b/src/deepwork/standard_jobs/deepwork_jobs/job.yml @@ -229,6 +229,7 @@ steps: "Stop Hooks Migrated": "Are `stop_hooks` migrated to `hooks.after_agent` format?" "Removed Steps Cleaned": "Are references to removed steps (like `review_job_spec`) updated?" "Orphaned Steps Fixed": "For jobs with no workflows, is there a single workflow (named after the job) containing all steps? For jobs with existing workflows, does each orphan get its own workflow (named after the step)?" + "Promise Lines Removed": "Are deprecated `Quality Criteria Met` lines removed from step instruction .md files?" "Valid YAML": "Are all job.yml files valid YAML?" - id: errata diff --git a/src/deepwork/standard_jobs/deepwork_jobs/steps/fix_jobs.md b/src/deepwork/standard_jobs/deepwork_jobs/steps/fix_jobs.md index 213588f4..8fb07d10 100644 --- a/src/deepwork/standard_jobs/deepwork_jobs/steps/fix_jobs.md +++ b/src/deepwork/standard_jobs/deepwork_jobs/steps/fix_jobs.md @@ -47,8 +47,9 @@ Then audit and repair the job at `.deepwork/jobs/[job_name]/job.yml`: 9. Replace `description:` with `common_job_info_provided_to_all_steps_at_runtime:` if present 10. Remove any info in `common_job_info_provided_to_all_steps_at_runtime` that is not relevant to most steps. 11. Read the step instructions and remove anything that is repeated in many steps and put it into `common_job_info_provided_to_all_steps_at_runtime` -12. Bump version if changes were made -13. Validate YAML syntax +12. Remove `Quality Criteria Met` lines from step instruction .md files +13. Bump version if changes were made +14. Validate YAML syntax Report only: which checks passed with no changes, and which changes were made (one line each). ``` @@ -252,7 +253,22 @@ steps: 3. **For steps with no quality_criteria**: Use `reviews: []` 4. **Remove the old field**: Delete the `quality_criteria` array entirely after migration. -### Step 8: Update Version Numbers +### Step 8: Remove Deprecated `Quality Criteria Met` from Step Instructions + +Old step instruction templates included a line telling the agent to self-attest quality by emitting a `` tag. This has been fully replaced by the structured `reviews` system with `QualityGate` evaluation. The old line serves no purpose and should be removed. + +**Find and remove lines like these from step instruction `.md` files:** + +```markdown +- When all criteria are met, include `✓ Quality Criteria Met` in your response +- When all criteria are met, include `Quality Criteria Met` in your response +``` + +**Where to look:** Check every `.md` file in each job's `steps/` directory. The line typically appears as the last bullet in a `## Quality Criteria` section. + +**What to do:** Delete the line entirely. Do not replace it with anything — the `reviews` system in `job.yml` now handles quality evaluation. + +### Step 9: Update Version Numbers If you made significant changes to a job, bump its version number: @@ -299,6 +315,7 @@ For each job in `.deepwork/jobs/`, check: | `stop_hooks` | Migrate to `hooks.after_agent` | | `outputs` format | Migrate from array to map with `type` and `description` | | `quality_criteria` | Migrate to `reviews` with `run_each` and map-format criteria | +| `` in step `.md` files | Remove deprecated `Quality Criteria Met` self-attestation lines | | Workflow steps | Remove references to deleted steps | | Dependencies | Update to valid step IDs | | File inputs | Update `from_step` references; update keys for renamed outputs | diff --git a/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.example b/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.example index 4f53b788..9b4217f8 100644 --- a/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.example +++ b/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.example @@ -75,7 +75,6 @@ A markdown document listing each competitor with context. - Each competitor has clear, specific description - Selection rationale explains the competitive landscape - Output is well-formatted and ready for use by next step -- When all criteria are met, include `✓ Quality Criteria Met` in your response ## Context diff --git a/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.template b/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.template index ddd19213..1f5f2c53 100644 --- a/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.template +++ b/src/deepwork/standard_jobs/deepwork_jobs/templates/step_instruction.md.template @@ -51,7 +51,6 @@ - [Quality criterion 1] - [Quality criterion 2] - [Quality criterion 3] -- When all criteria are met, include `✓ Quality Criteria Met` in your response ## Context