showSecondLayer crashes with empty options (#126)

* fixed bug in android

* improved ios tests

Author: uc-franciscocunha

android/src/androidTest/java/com/usercentrics/reactnativemodule/RNUsercentricsModuleTest.kt

@@ -674,7 +674,7 @@ class RNUsercentricsModuleTest {
     }
 
     @Test
-    fun testShowFirstLayer() {
+    fun testShowFirstLayerBannerSettingsObject() {
         val usercentricsProxy = FakeUsercentricsProxy()
         val contextMock = mockk<ReactApplicationContext>(relaxed = true)
         val module =
@@ -686,7 +686,33 @@ class RNUsercentricsModuleTest {
     }
 
     @Test
-    fun testShowSecondLayer() {
+    fun testShowFirstLayerWithNullBannerSettings() {
+        val usercentricsProxy = FakeUsercentricsProxy()
+        val contextMock = mockk<ReactApplicationContext>(relaxed = true)
+        val module =
+            RNUsercentricsModule(contextMock, usercentricsProxy, ReactContextProviderMock())
+        val promise = FakePromise()
+        module.showFirstLayer(null, promise)
+        promise.await()
+        assertEquals(null, usercentricsProxy.showFirstLayerBannerSettings)
+    }
+
+    @Test
+    fun testShowFirstLayerWithEmptyBannerSettingsObject() {
+        val bannerSettings = emptyMap<String, String>().toWritableMap()
+
+        val usercentricsProxy = FakeUsercentricsProxy()
+        val contextMock = mockk<ReactApplicationContext>(relaxed = true)
+        val module =
+            RNUsercentricsModule(contextMock, usercentricsProxy, ReactContextProviderMock())
+        val promise = FakePromise()
+        module.showFirstLayer(bannerSettings, promise)
+        promise.await()
+        assertEquals(BannerSettings(), usercentricsProxy.showFirstLayerBannerSettings)
+    }
+
+    @Test
+    fun testShowSecondLayerWithBannerSettingsObject() {
         val usercentricsProxy = FakeUsercentricsProxy()
         val contextMock = mockk<ReactApplicationContext>(relaxed = true)
         val module =
@@ -697,6 +723,32 @@ class RNUsercentricsModuleTest {
         assertEquals(expectedBannerSettings, usercentricsProxy.showSecondLayerBannerSettings)
     }
 
+    @Test
+    fun testShowSecondLayerWithNullBannerSettings() {
+        val usercentricsProxy = FakeUsercentricsProxy()
+        val contextMock = mockk<ReactApplicationContext>(relaxed = true)
+        val module =
+            RNUsercentricsModule(contextMock, usercentricsProxy, ReactContextProviderMock())
+        val promise = FakePromise()
+        module.showSecondLayer(null, promise)
+        promise.await()
+        assertEquals(null, usercentricsProxy.showSecondLayerBannerSettings)
+    }
+
+    @Test
+    fun testShowSecondLayerWithEmptyBannerSettingsObject() {
+        val bannerSettings = emptyMap<String, String>().toWritableMap()
+
+        val usercentricsProxy = FakeUsercentricsProxy()
+        val contextMock = mockk<ReactApplicationContext>(relaxed = true)
+        val module =
+            RNUsercentricsModule(contextMock, usercentricsProxy, ReactContextProviderMock())
+        val promise = FakePromise()
+        module.showSecondLayer(bannerSettings, promise)
+        promise.await()
+        assertEquals(BannerSettings(), usercentricsProxy.showSecondLayerBannerSettings)
+    }
+
     @Test
     fun testShowFirstLayerWithCustomLocalLogo() {
         val context = InstrumentationRegistry.getInstrumentation().context

android/src/main/java/com/usercentrics/reactnativeusercentrics/RNUsercentricsModule.kt

@@ -46,11 +46,11 @@ internal class RNUsercentricsModule(
     }
 
     @ReactMethod
-    fun showSecondLayer(options: ReadableMap, promise: Promise) {
+    fun showSecondLayer(options: ReadableMap?, promise: Promise) {
         runOnUiThread {
             try {
                 val context = reactContextProvider.context()
-                val bannerSettings = options.bannerSettingsFromMap(context)
+                val bannerSettings = options?.bannerSettingsFromMap(context)
 
                 val activity = reactContextProvider.activity()!!
                 usercentricsProxy.showSecondLayer(activity, bannerSettings, promise)

example/ios/exampleTests/RNUsercentricsModuleTests.swift

@@ -477,7 +477,7 @@ class RNUsercentricsModuleTests: XCTestCase {
     XCTAssertEqual(String("variantA"), fakeUsercentrics.variant)
   }
 
-  func testShowFirstLayer() {
+  func testShowFirstLayerWithBannerSettingsObject() {
     let serializedSettings: NSDictionary = [
       "firstLayerStyleSettings": ["layout": "POPUP_CENTER"]
     ]
@@ -487,8 +487,17 @@ class RNUsercentricsModuleTests: XCTestCase {
       XCTFail("Should not go here")
     }
   }
+  
+  func testShowFirstLayerWithEmptyBannerSettingsObject() {
+    let emptyDictionary: NSDictionary = [:]
+    module.showFirstLayer(emptyDictionary) { result in
+      XCTAssertNil(self.fakeUsercentrics.showFirstLayerBannerSettings?.firstLayerStyleSettings)
+    } reject: { _, _, _ in
+      XCTFail("Should not go here")
+    }
+  }
 
-  func testShowSecondLayer() {
+  func testShowSecondLayerWithBannerSettingsObject() {
     let serializedSettings: NSDictionary = [
       "secondLayerStyleSettings": ["showCloseButton": true]
     ]
@@ -498,6 +507,16 @@ class RNUsercentricsModuleTests: XCTestCase {
       XCTFail("Should not go here")
     }
   }
+  
+  func testShowSecondLayerWithEmptyBannerSettingsObject() {
+    let emptyDictionary: NSDictionary = [:]
+    
+    module.showSecondLayer(emptyDictionary) { result in
+      XCTAssertNil(self.fakeUsercentrics.showSecondLayerBannerSettings?.secondLayerStyleSettings)
+    } reject: { _, _, _ in
+      XCTFail("Should not go here")
+    }
+  }
 
   func testTrack() {
     module.track(1)