fix(treewide): Fix virtual/override annotations

Signed-off-by: Philipp Jungkamp <philipp.jungkamp@rwth-aachen.de>

Author: pjungkamp

clients/shmem/villas-shmem.cpp

@@ -34,7 +34,7 @@ class Shmem : public Tool {
 protected:
   std::atomic<bool> stop;
 
-  void usage() {
+  void usage() override {
     std::cout
         << "Usage: villas-test-shmem WNAME VECTORIZE" << std::endl
         << "  WNAME     name of the shared memory object for the output queue"
@@ -47,9 +47,9 @@ class Shmem : public Tool {
     printCopyright();
   }
 
-  void handler(int, siginfo_t *, void *) { stop = true; }
+  void handler(int, siginfo_t *, void *) override { stop = true; }
 
-  int main() {
+  int main() override {
     int ret, readcnt, writecnt, avail;
 
     struct ShmemInterface shm;

common/include/villas/dsp/window_cosine.hpp

@@ -27,7 +27,7 @@ class CosineWindow : public Window<T> {
 
   T correctionFactor;
 
-  virtual T filter(T in, size_type i) const { return in * coefficients[i]; }
+  T filter(T in, size_type i) const override { return in * coefficients[i]; }
 
 public:
   CosineWindow(double a0, double a1, double a2, double a3, double a4,

include/villas/api/request.hpp

@@ -103,7 +103,7 @@ class RequestFactory : public plugin::Plugin {
 
   virtual void init(Request *r) { r->logger = getLogger(); }
 
-  virtual std::string getType() const { return "api:request"; }
+  std::string getType() const override { return "api:request"; }
 
   virtual bool isHidden() const { return false; }
 };
@@ -117,7 +117,7 @@ class RequestPlugin : public RequestFactory {
 public:
   RequestPlugin() : RequestFactory(), regex(re) {}
 
-  virtual Request *make(Session *s) {
+  Request *make(Session *s) override {
     auto *r = new T(s);
 
     init(r);
@@ -126,12 +126,12 @@ class RequestPlugin : public RequestFactory {
   }
 
   // Get plugin name
-  virtual std::string getName() const { return name; }
+  std::string getName() const override { return name; }
 
   // Get plugin description
-  virtual std::string getDescription() const { return desc; }
+  std::string getDescription() const override { return desc; }
 
-  virtual bool match(const std::string &uri, std::smatch &match) const {
+  bool match(const std::string &uri, std::smatch &match) const override {
     return std::regex_match(uri, match, regex);
   }
 };

include/villas/api/response.hpp

@@ -65,9 +65,9 @@ class JsonResponse : public Response {
   JsonResponse(Session *s, int c, json_t *r)
       : Response(s, c, "application/json"), response(r) {}
 
-  virtual ~JsonResponse();
+  ~JsonResponse() override;
 
-  virtual void encodeBody();
+  void encodeBody() override;
 };
 
 class ErrorResponse : public JsonResponse {

include/villas/format.hpp

@@ -127,7 +127,7 @@ class FormatFactory : public plugin::Plugin {
 
   virtual void init(Format *f) { f->logger = getLogger(); }
 
-  virtual std::string getType() const { return "format"; }
+  std::string getType() const override { return "format"; }
 
   virtual bool isHidden() const { return false; }
 };
@@ -138,17 +138,17 @@ class FormatPlugin : public FormatFactory {
 public:
   using FormatFactory::FormatFactory;
 
-  virtual Format *make() {
+  Format *make() override {
     auto *f = new T(flags);
 
     init(f);
 
     return f;
   }
 
-  virtual std::string getName() const { return name; }
+  std::string getName() const override { return name; }
 
-  virtual std::string getDescription() const { return desc; }
+  std::string getDescription() const override { return desc; }
 };
 
 } // namespace node

include/villas/formats/villas_binary.hpp

@@ -60,7 +60,7 @@ class VillasBinaryFormatPlugin : public FormatFactory {
   }
 
   // Get plugin description
-  virtual std::string getDescription() const {
+  std::string getDescription() const override {
     std::stringstream ss;
 
     ss << "VILLAS binary network format";

include/villas/hook.hpp

@@ -131,9 +131,9 @@ class SingleSignalHook : public Hook {
   SingleSignalHook(Path *p, Node *n, int fl, int prio, bool en = true)
       : Hook(p, n, fl, prio, en), signalIndex(0) {}
 
-  virtual void parse(json_t *json);
+  void parse(json_t *json) override;
 
-  virtual void prepare();
+  void prepare() override;
 };
 
 class MultiSignalHook : public Hook {
@@ -145,11 +145,11 @@ class MultiSignalHook : public Hook {
 public:
   using Hook::Hook;
 
-  virtual void parse(json_t *json);
+  void parse(json_t *json) override;
 
-  virtual void prepare();
+  void prepare() override;
 
-  virtual void check();
+  void check() override;
 };
 
 class LimitHook : public Hook {
@@ -160,7 +160,7 @@ class LimitHook : public Hook {
 
   virtual void setRate(double rate, double maxRate = -1) = 0;
 
-  virtual void parse(json_t *json) {
+  void parse(json_t *json) override {
     assert(state == State::INITIALIZED);
 
     state = State::PARSED;
@@ -191,7 +191,7 @@ class HookFactory : public plugin::Plugin {
 
   virtual unsigned getPriority() const = 0;
 
-  virtual std::string getType() const { return "hook"; }
+  std::string getType() const override { return "hook"; }
 
   virtual bool isHidden() const { return false; }
 };
@@ -203,21 +203,21 @@ class HookPlugin : public HookFactory {
 public:
   using HookFactory::HookFactory;
 
-  virtual Hook::Ptr make(Path *p, Node *n) {
+  Hook::Ptr make(Path *p, Node *n) override {
     auto h = std::make_shared<T>(p, n, getFlags(), getPriority());
 
     init(h);
 
     return h;
   }
 
-  virtual std::string getName() const { return name; }
+  std::string getName() const override { return name; }
 
-  virtual std::string getDescription() const { return desc; }
+  std::string getDescription() const override { return desc; }
 
-  virtual int getFlags() const { return flags; }
+  int getFlags() const override { return flags; }
 
-  virtual unsigned getPriority() const { return prio; }
+  unsigned getPriority() const override { return prio; }
 };
 
 } // namespace node

include/villas/hooks/lua.hpp

@@ -105,7 +105,7 @@ class LuaHook : public Hook {
 public:
   LuaHook(Path *p, Node *n, int fl, int prio, bool en = true);
 
-  virtual ~LuaHook();
+  ~LuaHook() override;
 
   void parse(json_t *json) override;
 

include/villas/node.hpp

@@ -316,7 +316,7 @@ class NodeFactory : public villas::plugin::Plugin {
   static Node *make(const std::string &type, const uuid_t &id = {},
                     const std::string &name = "");
 
-  virtual std::string getType() const { return "node"; }
+  std::string getType() const override { return "node"; }
 
   friend std::ostream &operator<<(std::ostream &os, const NodeFactory &f) {
     os << f.getName();
@@ -346,21 +346,21 @@ template <typename T, const char *name, const char *desc, int flags = 0,
 class NodePlugin : public NodeFactory {
 
 public:
-  virtual Node *make(const uuid_t &id = {}, const std::string &nme = "") {
+  Node *make(const uuid_t &id = {}, const std::string &nme = "") override {
     T *n = new T(id, nme);
 
     init(n);
 
     return n;
   }
 
-  virtual int getFlags() const { return flags; }
+  int getFlags() const override { return flags; }
 
-  virtual int getVectorize() const { return vectorize; }
+  int getVectorize() const override { return vectorize; }
 
-  virtual std::string getName() const { return name; }
+  std::string getName() const override { return name; }
 
-  virtual std::string getDescription() const { return desc; }
+  std::string getDescription() const override { return desc; }
 };
 
 } // namespace node

include/villas/node_compat.hpp

@@ -39,7 +39,7 @@ class NodeCompat : public Node {
 
   NodeCompat &operator=(const NodeCompat &other);
 
-  virtual ~NodeCompat();
+  ~NodeCompat() override;
 
   template <typename T> T *getData() { return static_cast<T *>(_vd); }