Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project-s: 初期化とシンガー・楽譜を設定するaction/mutationを追加 #988

Merged

Conversation

sigprogramming
Copy link
Contributor

内容

SingingStoreStateの初期化と、以下のaction/mutationを追加します。

  • シンガーの設定
  • デフォルトScoreの取得
  • Scoreの設定

デフォルトシンガーの設定は、ひとまずSET_SINGERで行っています。
ご意見、ご指摘等いただけますと幸いです。

関連 Issue

ref VOICEVOX/voicevox_project#15
ref #981

@sigprogramming sigprogramming changed the title 初期化とシンガー・楽譜を設定するaction/mutationを追加 [project-s] 初期化とシンガー・楽譜を設定するaction/mutationを追加 Oct 19, 2022
@sigprogramming sigprogramming changed the title [project-s] 初期化とシンガー・楽譜を設定するaction/mutationを追加 project-s: 初期化とシンガー・楽譜を設定するaction/mutationを追加 Oct 19, 2022
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

SET_SINGER当たりのコードは見慣れないかもですが、テキスト音声合成側と似てる感じだと思うのでとりあえず大丈夫そうなのかなと思いました!

src/store/singing.ts Show resolved Hide resolved
Copy link
Contributor

@romot-co romot-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

遅くなり失礼しました!LGTMです!

src/views/SingerHome.vue Show resolved Hide resolved
@sigprogramming sigprogramming merged commit dcb4cd1 into VOICEVOX:project-s Oct 26, 2022
@sigprogramming sigprogramming deleted the feature/add_initialization branch November 3, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants