Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of public static User fromUserData(UserData ud) #1

Open
kapitancho opened this issue Jun 24, 2020 · 0 comments
Open

Get rid of public static User fromUserData(UserData ud) #1

kapitancho opened this issue Jun 24, 2020 · 0 comments

Comments

@kapitancho
Copy link

Hi,
There is a method public static User fromUserData(UserData ud) in the User class. I think that due to dependency concerns this function should not be there. If you get rid of it, the class User will have no external dependencies and it will remain pure. This would also be compatible with DDD.
But in general... great job with this example!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kapitancho