From ff2ef9a6038d8ad1c4946335c2f609d511f48f90 Mon Sep 17 00:00:00 2001 From: Zhaofeng Zhang <24791380+vcfgv@users.noreply.github.com> Date: Wed, 26 Nov 2025 14:28:42 +0800 Subject: [PATCH] fix: prevent redundant fee deduction from account balance --- python/valuecell/agents/common/trading/_internal/coordinator.py | 1 + python/valuecell/agents/common/trading/portfolio/in_memory.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/python/valuecell/agents/common/trading/_internal/coordinator.py b/python/valuecell/agents/common/trading/_internal/coordinator.py index d3597d19d..0932c6493 100644 --- a/python/valuecell/agents/common/trading/_internal/coordinator.py +++ b/python/valuecell/agents/common/trading/_internal/coordinator.py @@ -350,6 +350,7 @@ def _create_trades( exit_ts=exit_ts, trade_ts=timestamp_ms, holding_ms=(exit_ts - entry_ts_prev) if entry_ts_prev else None, + unrealized_pnl=0.0, realized_pnl=realized_pnl, realized_pnl_pct=realized_pnl_pct, # For a full close, reflect the leverage of the closed position, not the closing instruction diff --git a/python/valuecell/agents/common/trading/portfolio/in_memory.py b/python/valuecell/agents/common/trading/portfolio/in_memory.py index 3a843adfe..1d32627ea 100644 --- a/python/valuecell/agents/common/trading/portfolio/in_memory.py +++ b/python/valuecell/agents/common/trading/portfolio/in_memory.py @@ -206,7 +206,7 @@ def apply_trades( else: # Derivatives: Cash (Wallet Balance) only changes by Realized PnL and Fees # Notional is not deducted from cash. - self._view.account_balance -= fee + # self._view.account_balance -= fee self._view.account_balance += realized_delta total_realized += realized_delta