Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Issue]: /upload/image is Returning Raw JSON Data if Listing is Not Found #46

Closed
2 tasks done
Rucha-Ambaliya opened this issue Jan 12, 2025 · 5 comments · Fixed by #47
Closed
2 tasks done
Assignees
Labels

Comments

@Rucha-Ambaliya
Copy link
Contributor

📝 Issue Description

When making a request to the /upload/image endpoint, if the requested listing is not found, the API currently responds with raw JSON data. This behavior is inconsistent with the expected output, which should follow the defined model format.

🎯 Expected Outcome

The API should return the response in its defined model format, even if the listing is not found.

Proposed Solution

  • Modify the controller logic for /upload/image to ensure that the response adheres to the defined model format.

📋 Additional Context

No response

📜 Confirmation

  • I have reviewed the existing issues to avoid duplication
  • I have provided sufficient detail for others to understand the issue
@github-actions github-actions bot added good first issue Good for newcomers SWOC labels Jan 12, 2025
Copy link

👋 Thanks for opening this issue!

This issue has been automatically labeled with swoc and good first issue tags by our GitHub Actions bot 🤖.

Feel free to start working on this issue by:

  1. Commenting below to get assigned
  2. Creating a fork of the repository
  3. Making your changes in a new branch
  4. Opening a pull request

Need help? Join our Discord community!

This is an automated message from SocioSell's GitHub Actions bot 🦾

@kashifalikhan36
Copy link
Contributor

Please assign me this issue

@Varsha-1605
Copy link
Owner

@kashifalikhan36 already assigned to someone else!

@kashifalikhan36
Copy link
Contributor

@Varsha-1605 ooh Okay, I'll look for issues I can work on."

@Varsha-1605
Copy link
Owner

@kashifalikhan36 You can also raise new issues !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants