Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Custom Issue]: Add Support for Multiple Image Uploads on the Upload Image Page #58

Open
2 tasks done
Rucha-Ambaliya opened this issue Jan 15, 2025 · 19 comments
Open
2 tasks done
Labels
good first issue Good for newcomers SWOC

Comments

@Rucha-Ambaliya
Copy link
Contributor

📝 Issue Description

The current UI on the index.html upload image page allows users to upload only a single image at a time. However, the backend supports uploading up to 5 images simultaneously. This feature enhancement would enable users to upload multiple images in a single interaction, aligning the frontend with backend capabilities.

🎯 Expected Outcome

  • Update the file input field in the index.html to accept multiple files.
  • Add a visual indicator or label to inform users they can upload up to 5 images.
  • Implement any necessary JavaScript updates to handle multiple file uploads efficiently.
  • Ensure appropriate error messages are displayed if the user tries to upload more than 5 images.

📋 Additional Context

No response

📜 Confirmation

  • I have reviewed the existing issues to avoid duplication
  • I have provided sufficient detail for others to understand the issue
Copy link

👋 Thanks for opening this issue!

This issue has been automatically labeled with swoc and good first issue tags by our GitHub Actions bot 🤖.

Feel free to start working on this issue by:

  1. Commenting below to get assigned
  2. Creating a fork of the repository
  3. Making your changes in a new branch
  4. Opening a pull request

Need help? Join our Discord community!

This is an automated message from SocioSell's GitHub Actions bot 🦾

@github-actions github-actions bot added good first issue Good for newcomers SWOC labels Jan 15, 2025
@Rucha-Ambaliya Rucha-Ambaliya changed the title [Custom Issue]: [Custom Issue]: Add Support for Multiple Image Uploads on the Upload Image Page Jan 15, 2025
@Varsha-1605
Copy link
Owner

Varsha-1605 commented Jan 15, 2025

@Rucha-Ambaliya what would be benefit if we do this and this project basically outcome???
cus at a time we can get recommendation of each product.
think in that way

@Rucha-Ambaliya
Copy link
Contributor Author

I thought if backend is accepting 5 files since very starting, then it must have been the need of the project. If one file is enough then I can work on integrating image_processor.py to main.py... But for that connection with AI API is needed which is being covered by another contributor. It is the same case for video_processor.py, but I think I would rather start with image processing than video processing since it is quite new to me, and working with image might be less tricky.

@mdimado
Copy link

mdimado commented Jan 15, 2025

It would be helpful to clarify how enabling multiple image uploads aligns with the project's overall objectives. For instance, if the focus is on providing recommendations per product, would uploading multiple images simultaneously impact this workflow positively or negatively?

Adding support for multiple uploads should consider the end-user experience. If we proceed, perhaps we could include a preview or progress bar for uploaded images to make the process more user-friendly.

Since the backend already supports multiple uploads, the frontend changes seem reasonable. However, error handling (e.g., limiting uploads to 5 images) and edge cases (e.g., varying image sizes or unsupported formats) should be tested thoroughly to avoid introducing bugs.

I can work on the following, if assigned:

  • Update the frontend to allow multiple file uploads.
  • Add a visual indicator and error handling.
  • Test the entire workflow to ensure compatibility with the backend.

@Varsha-1605
Copy link
Owner

@mdimado Make sure these changes must reflect on the website not only on fastAPI, now the project is deployed so keep it in mind.

@Varsha-1605
Copy link
Owner

@Rucha-Ambaliya so you want to work on integration part??? which one as per your tech stacks and excellence raise issue or continue with already present.

@Rucha-Ambaliya
Copy link
Contributor Author

Rucha-Ambaliya commented Jan 15, 2025

This issue was to allow users to upload multiple images but you said it might not be necessary so I gave alternatives I could work on...

Also I had raised the issue of allowing multiple file uploads, so if it is needed I would like to work on it, while ensuring other ui features like progress bar are also included

@Varsha-1605
Copy link
Owner

@Rucha-Ambaliya when did i say it might not be necessary??
You raised issue then i asked you but didn't answer me what i was expecting and changed ur track and if someone has answered then i assigned him.

@Rucha-Ambaliya
Copy link
Contributor Author

As I mentioned earlier, this change was intended to align the frontend with the backend’s capability of handling multiple image uploads. I just wanted to confirm if this change seems relevant to the project’s goals. If not, I had also proposed other changes I could work on in place of this. Additionally, the changes that @mdimado is going to work on were also mentioned in my issue, which is why I thought I could contribute to them. However, before we could discuss further, the task was assigned. However, I’m happy to see progress being made and am available to assist with any other aspects if needed.

@Varsha-1605
Copy link
Owner

@Rucha-Ambaliya I understand that you raise an issue and I assigned it to someone but the thing is you are one of the contributors who is doing most contributions for this project. It can be seen as a partial behavior it is essential others also get chance to contribute. Recently one of the contributors and pa has been kicked out of the program because of the partial behavior.

I hope now you can understand!

@Rucha-Ambaliya
Copy link
Contributor Author

Yes, I have seen that, and I completely understand the importance of ensuring equal distribution of work. I also realize I could have communicated better about how I see this work contributing to the project as a whole. My intention was to avoid any further communication gaps, and I truly appreciate your understanding. Please know that I have no hard feelings, and I hope we can move forward with clarity and collaboration.

@Varsha-1605
Copy link
Owner

@Rucha-Ambaliya Raise any issue or choose from the existing ones.

@Rucha-Ambaliya
Copy link
Contributor Author

Sure!

@Varsha-1605
Copy link
Owner

@mdimado any update on work as it's been two days complete it by today else i have to assign it to someone else.

@mdimado
Copy link

mdimado commented Jan 17, 2025

thanks for the opportunity to contribute. due to time constraints and challenges understanding the codebase, i won’t be able to give this task the attention it needs. apologies for the inconvenience, and i kindly request to be unassigned so someone else can take it up. i hope to contribute to future tasks when i have more bandwidth.

@Varsha-1605
Copy link
Owner

@Rucha-Ambaliya would you like to work on this task?

@Rucha-Ambaliya
Copy link
Contributor Author

Sure, I’d be happy to take it up. However, I currently have other prior commitments that I need to focus on. I’ll need a few days before I can actively start working on this. Please let me know if that works.

@Varsha-1605
Copy link
Owner

@Rucha-Ambaliya sure but if someone else ask me for assignment before you, I have to assign that person.

@Rucha-Ambaliya
Copy link
Contributor Author

Sure, no problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers SWOC
Projects
None yet
Development

No branches or pull requests

3 participants