From 033eb7dce693d0a6741987807aafa3e7534de80d Mon Sep 17 00:00:00 2001 From: Amrit K Date: Mon, 13 Nov 2023 17:21:45 -0500 Subject: [PATCH] Fix typing for kwargs parameter in create_metric_fn --- .gitignore | 1 + cyclops/evaluate/metrics/factory.py | 6 +++--- docs/source/tutorials/nihcxr/generate_nihcxr_report.py | 8 ++++---- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.gitignore b/.gitignore index cda4fe016..ca521aafc 100644 --- a/.gitignore +++ b/.gitignore @@ -29,3 +29,4 @@ _autosummary *cyclops_reports* *dummy_reports* .mypy_cache +*code-workspace* diff --git a/cyclops/evaluate/metrics/factory.py b/cyclops/evaluate/metrics/factory.py index be38a4043..e83d76b55 100644 --- a/cyclops/evaluate/metrics/factory.py +++ b/cyclops/evaluate/metrics/factory.py @@ -1,19 +1,19 @@ """Factory for creating metrics.""" from difflib import get_close_matches -from typing import Any, List, Mapping, Optional +from typing import Any, List from cyclops.evaluate.metrics.metric import _METRIC_REGISTRY, Metric -def create_metric(metric_name: str, **kwargs: Optional[Mapping[str, Any]]) -> Metric: +def create_metric(metric_name: str, **kwargs: Any) -> Metric: """Create a metric instance from a name. Parameters ---------- metric_name : str The name of the metric. - **kwargs : Mapping[str, Any], optional + **kwargs : Any The keyword arguments to pass to the metric constructor. Returns diff --git a/docs/source/tutorials/nihcxr/generate_nihcxr_report.py b/docs/source/tutorials/nihcxr/generate_nihcxr_report.py index a0d4250e8..364742352 100644 --- a/docs/source/tutorials/nihcxr/generate_nihcxr_report.py +++ b/docs/source/tutorials/nihcxr/generate_nihcxr_report.py @@ -150,14 +150,14 @@ def compute(self) -> npt.NDArray[np.int_]: specificity = create_metric( metric_name="specificity", - task="multilabel", # type: ignore[arg-type] - num_labels=len(pathologies), # type: ignore[arg-type] + task="multilabel", + num_labels=len(pathologies), ) sensitivity = create_metric( metric_name="sensitivity", - task="multilabel", # type: ignore[arg-type] - num_labels=len(pathologies), # type: ignore[arg-type] + task="multilabel", + num_labels=len(pathologies), ) # create the slice functions slice_spec = SliceSpec(spec_list=slices_sex)