Skip to content

Add aliases for precision and recall #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

fcogidi
Copy link
Collaborator

@fcogidi fcogidi commented Dec 19, 2023

PR Type

Feature.

Short Description

Add aliases for Precision (Positive Predictive Value) and recall (Sensitivity and True Positive Rate).

Tests Added

None.

@fcogidi fcogidi added the enhancement New feature or request label Dec 19, 2023
@fcogidi fcogidi requested a review from amrit110 December 19, 2023 17:21
@fcogidi fcogidi self-assigned this Dec 19, 2023
@fcogidi
Copy link
Collaborator Author

fcogidi commented Dec 19, 2023

@amrit110 What do you think of the names: binary_ppv vs. binary_positive_predictive_value or binary_tpr vs binary_true_positive_rate?

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b31425) 68.25% compared to head (8b83d10) 68.49%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   68.25%   68.49%   +0.24%     
==========================================
  Files         104      106       +2     
  Lines       10041    10118      +77     
==========================================
+ Hits         6853     6930      +77     
  Misses       3188     3188              
Files Coverage Δ
...etrics/experimental/functional/precision_recall.py 100.00% <100.00%> (ø)
.../evaluate/metrics/experimental/precision_recall.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Impacted file tree graph

@amrit110
Copy link
Member

@fcogidi yeah i like the shorter names. not much value there to be verbose.

@fcogidi fcogidi merged commit 725a781 into main Dec 19, 2023
@fcogidi fcogidi deleted the add_aliases_for_precision_and_recall branch December 19, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants