From 2290729fcc1b3775141b54ff71a295bd29457fbd Mon Sep 17 00:00:00 2001 From: f41gh7 Date: Mon, 9 Jan 2023 17:53:36 +0100 Subject: [PATCH] controllers/vmalert: fixes notifier match condition for namespace selector https://github.com/VictoriaMetrics/operator/issues/569 --- controllers/factory/vmalert.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controllers/factory/vmalert.go b/controllers/factory/vmalert.go index 406ef40e..6e394b77 100644 --- a/controllers/factory/vmalert.go +++ b/controllers/factory/vmalert.go @@ -152,7 +152,7 @@ func CreateOrUpdateVMAlert(ctx context.Context, cr *victoriametricsv1beta1.VMAle return reconcile.Result{}, fmt.Errorf("cannot list alertmanagers for vmalert notifier sd: %w", err) } for _, item := range ams.Items { - if !item.DeletionTimestamp.IsZero() && (n.Selector.Namespace != nil && !n.Selector.Namespace.IsMatch(&item)) { + if !item.DeletionTimestamp.IsZero() || (n.Selector.Namespace != nil && !n.Selector.Namespace.IsMatch(&item)) { continue } dsc := item.AsNotifiers()