From 88824e5984455fe35be9e8a1f0ec77a31bc24cd3 Mon Sep 17 00:00:00 2001 From: Graham Rogers Date: Mon, 16 Sep 2024 15:31:17 +0100 Subject: [PATCH 1/2] Update `with_controller_class` type documentation --- lib/view_component/test_helpers.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/view_component/test_helpers.rb b/lib/view_component/test_helpers.rb index 0dfbe7a85..3677763fb 100644 --- a/lib/view_component/test_helpers.rb +++ b/lib/view_component/test_helpers.rb @@ -155,7 +155,7 @@ def with_variant(variant) # end # ``` # - # @param klass [ActionController::Base] The controller to be used. + # @param klass [Class] The controller to be used. def with_controller_class(klass) old_controller = defined?(@vc_test_controller) && @vc_test_controller From 6f5541e170c8e9f506a72193f5cf2a762f09ab7d Mon Sep 17 00:00:00 2001 From: Graham Rogers Date: Mon, 16 Sep 2024 18:57:43 +0100 Subject: [PATCH 2/2] Updated CHANGELOG.md --- docs/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index 9adbe3962..b3c577e5d 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -42,6 +42,10 @@ nav_order: 5 *Petrik de Heus* +* Fixed type declaration for `ViewComponent::TestHelpers.with_controller_class` parameter. + + *Graham Rogers* + ## 3.14.0 * Defer to built-in caching for language environment setup, rather than manually using `actions/cache` in CI.