Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Add Dockerfile #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

gardner
Copy link

@gardner gardner commented Dec 1, 2023

Add Dockerfile
Update installation scripts to work without sudo if run as root
Set execution bit on *.sh

@gardner
Copy link
Author

gardner commented Dec 1, 2023

Hey! Great work!
I added a docker config for cuda configurations.
I just noticed you have a dev branch. Please let me know if you'd prefer PRs to dev.

@gardner
Copy link
Author

gardner commented Dec 1, 2023

I noticed there is an issue where this configuration will not convert multiple files.

This issue can be reproduced by setting the command: in docker-compose.yml to:

python convert.py /input /output --workers 10 --max 10 --min_length 10000

Then run docker compose run marker ; ls output/
Please note there are no output files.

@VikParuchuri
Copy link
Owner

VikParuchuri commented Dec 1, 2023

Thank you for this, @gardner ! Is there any easy way to get this to work with or without a cuda device? I imagine it would need a different base image.

Also, any reason to use 11.8 over 12 for cuda?

@justinmclark
Copy link

Hi - I'm not an active contributor so please take what I say with a grain of salt. I would comment on an Issue if there was one. Please disregard if this isn't the place.

In my particular use case, a Docker container that exposes an API I can repeated call over HTTP would be significantly more helpful and a Docker container used as a sort of command line function call. This makes it useful in a cloud deployment situation. E.g. I could just push this to Google Cloud Run and have a functioning/scaling endpoint to convert PDFs to markdown.

Anyways, I'm going to be writing one for my own use but would be happy to post here when finished.

@davanstrien
Copy link

davanstrien commented Mar 6, 2024

Anyways, I'm going to be writing one for my own use but would be happy to post here when finished.

@justinmclark, did you get around to doing this? Something like this would also be very useful for me right now!

@gardner gardner force-pushed the master branch 6 times, most recently from 56bd9d6 to 10fa67e Compare March 7, 2024 07:40
@gardner gardner changed the title Add Dockerfile DRAFT: Add Dockerfile Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants