Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VFB workshop feature requests #57

Open
schlegelp opened this issue Mar 3, 2021 · 2 comments
Open

VFB workshop feature requests #57

schlegelp opened this issue Mar 3, 2021 · 2 comments

Comments

@schlegelp
Copy link

schlegelp commented Mar 3, 2021

Collecting feature requests from the workshop here:

  • for convenience, it'd be nice if single search parameters (e.g. types or VFB IDs) would not need to be wrapped in lists but can be provided as just a string
  • return pandas.DataFrames by default and make raw data return optional (e.g. via return_json=True)
  • docstrings (I appreciate that this might have to wait until the API is more stable)

Maybe @jefferis and others might like to pitch in and add stuff.

@jefferis
Copy link

jefferis commented Mar 3, 2021

Those were the main ones we discussed. They come up multiple times in different groups.

@dosumis
Copy link
Member

dosumis commented May 5, 2021

for convenience, it'd be nice if single search parameters (e.g. types or VFB IDs) would not need to be wrapped in lists but can be provided as just a string

More flexible to allow list input

return pandas.DataFrames by default and make raw data return optional (e.g. via return_json=True)

Agreed (we need the JSON return on all methods so they can be exposed through the REST API). However, changing the default will break NoteBook examples, so we should tie these to compatible versions

docstrings (I appreciate that this might have to wait until the API is more stable)

These are actually all fixed, e.g. see https://vfb-connect.readthedocs.io/en/stable/API_reference.html , but we had some problem with the last release (reverting to 1.2.5 on pip install). Fixing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants