Dataset missing from CATMAID neurons

[mmc46]

It seems that some (?) of the FAFB CATMAID neurons are missing the dataset column when querying with vc$get_images_by_type. They still have the data_source one.
Not clear if this is an issue with the data being missing now, or just the function output.

vc$get_images_by_type
<bound method VfbConnect.get_images_by_type of <vfb_connect.cross_server_tools.VfbConnect>>

library(vfbconnectr)
library(dplyr)

vc = VfbConnect()

DA1_manifest = vc$get_images_by_type("'adult antennal lobe projection neuron DA1'", template = 'JRC2018Unisex', image_folder = 'DA1', stomp=TRUE)

table(DA1_manifest$dataset, DA1_manifest$data_source)
#>       
#>        catmaid_fafb neuprint_JRC_Hemibrain_1point1
#>   None           17                              8

Same for another query for FAFB CATMAID neurons, so it could be a general issue.

sayin_tab = vc$get_instances_by_dataset('Sayin2019', summary=T) %>% vc_df()
table(sayin_tab$dataset)

None 
   2 

#and
vc$neo_query_wrapper$get_anatomical_individual_TermInfo(list('VFB_001012ay'), summary = T) %>% vc_df() %>%count(dataset)
  dataset n
1    None 1

FYI @jefferis

[dosumis]

This uses a query that runs on the VFB site. I assume it's failing here because of out of date cypher + DB changes, as it works fine on the VFB site.

@Robbie1977 - currently these are kept in sync by hand using vfb_query_builder.query_roller.TermInfoExport() to overwrite vfb_connect/resources/VFB_TermInfo_queries.json. Could we automate this with a GitHub action?

[Robbie1977]

@dosumis If you're happy you can merge #66 and create a new release.