Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expression runner to use FBco ID as a way of detecting splits #285

Open
Tracked by #283
dosumis opened this issue Mar 22, 2024 · 0 comments
Open
Tracked by #283
Assignees

Comments

@dosumis
Copy link
Member

dosumis commented Mar 22, 2024

Line 234 detects whether FBex represents split or not by checking for a comment in the internal processing DB. This finds non split expression
q = engine.execute("SELECT tg FROM feature_expression WHERE comment IS NULL AND tg is NOT NULL")
A similar statement in proc_splits finds splits in the DB.

Proposed Fix: change this to match FBex.uniquename ~ 'FBco.+'

The comment will be null if it does not match the pattern in the original SQL query for FB
L173 "AND fep.value ~ 'when combined with @.@.'"
+ limit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants