Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish the WASM test in scala-cli main repo #3256

Open
Quafadas opened this issue Nov 4, 2024 · 0 comments
Open

Finish the WASM test in scala-cli main repo #3256

Quafadas opened this issue Nov 4, 2024 · 0 comments
Labels
bug Something isn't working Scala.js WASM

Comments

@Quafadas
Copy link
Contributor

Quafadas commented Nov 4, 2024

Version(s)
1.5.1

Describe the bug
This PR #3255 set out to add the ability to emit WASM from scala-cli. It omits (at this point)
https://github.com/Quafadas/scala-cli/blob/a26687a57d1e247ed5b89d82790aa377cd0f43c4/modules/integration/src/test/scala/scala/cli/integration/RunScalaJsTestDefinitions.scala#L327

in the test, actually running the emitted WASM. Instead, we assume it works transitively - it is tested here in the precursor PR to scala-js-cli.

https://github.com/VirtusLab/scala-js-cli/blob/ad320d48d18c4b3d586c26d907749c0c539f6be6/tests/test/src/org/scalajs/cli/tests/Tests.scala#L558

Running WASM requires node 22+ in GHA. As it's unclear (to me) what the implications of upgrading node in the scala-cli repo are, the PR is left "incomplete" by agreement. If node 22 was available, it should be the case, that copying and pasting the line linked above into scala-cli main would close the loop.

To Reproduce
Observe the TODO in the code.

Expected behaviour
scala-cli tests that the trivial WASM module it emits, runs as expected.

@Gedochao

@Quafadas Quafadas added the bug Something isn't working label Nov 4, 2024
@Quafadas Quafadas changed the title Finish the WASM test in CLI repository Finish the WASM test in scala-cli main Nov 4, 2024
@Quafadas Quafadas changed the title Finish the WASM test in scala-cli main Finish the WASM test in scala-cli main repo Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Scala.js WASM
Projects
None yet
Development

No branches or pull requests

2 participants