You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running WASM requires node 22+ in GHA. As it's unclear (to me) what the implications of upgrading node in the scala-cli repo are, the PR is left "incomplete" by agreement. If node 22 was available, it should be the case, that copying and pasting the line linked above into scala-cli main would close the loop.
To Reproduce
Observe the TODO in the code.
Expected behaviour
scala-cli tests that the trivial WASM module it emits, runs as expected.
Version(s)
1.5.1
Describe the bug
This PR #3255 set out to add the ability to emit WASM from scala-cli. It omits (at this point)
https://github.com/Quafadas/scala-cli/blob/a26687a57d1e247ed5b89d82790aa377cd0f43c4/modules/integration/src/test/scala/scala/cli/integration/RunScalaJsTestDefinitions.scala#L327
in the test, actually running the emitted WASM. Instead, we assume it works transitively - it is tested here in the precursor PR to scala-js-cli.
https://github.com/VirtusLab/scala-js-cli/blob/ad320d48d18c4b3d586c26d907749c0c539f6be6/tests/test/src/org/scalajs/cli/tests/Tests.scala#L558
Running WASM requires node 22+ in GHA. As it's unclear (to me) what the implications of upgrading node in the scala-cli repo are, the PR is left "incomplete" by agreement. If node 22 was available, it should be the case, that copying and pasting the line linked above into scala-cli main would close the loop.
To Reproduce
Observe the TODO in the code.
Expected behaviour
scala-cli tests that the trivial WASM module it emits, runs as expected.
@Gedochao
The text was updated successfully, but these errors were encountered: