Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It looks wrong on Android 7.1 #221

Open
escobar5 opened this issue Feb 6, 2017 · 14 comments
Open

It looks wrong on Android 7.1 #221

escobar5 opened this issue Feb 6, 2017 · 14 comments

Comments

@escobar5
Copy link

escobar5 commented Feb 6, 2017

It has a strange space at the right.

screenshot_20170206-155720

@tavosansal
Copy link

I can also confirm this. Extra spacing on the right side.

@uzumakinaruto123
Copy link

Its not the plugin issue ! Its according to density pixels of a device. Its a native datepicker , and same happens with it. You can check by changing pixel density on your device.

@tavosansal
Copy link

@uzumakinaruto123 Thanks for your reply. Total noob question but how does one go about changing pixel density?

@uzumakinaruto123
Copy link

@tavosansal you can try this adb command : -adb shell wm density 400 && adb reboot you can remove && adb reboot.

But , I suggest you don't do it. I keep mine at 400(one plus 3) because I like everything small.

If you want to try then , please note your default density before doing. You will have to try different values to make date picker look correct.

you can try few apps here :- https://play.google.com/store/search?q=screen%20density&c=apps

some apps require root. Anyways , this is getting off topic for the plugin.

@escobar5
Copy link
Author

escobar5 commented Feb 23, 2017

@uzumakinaruto123 if it was a problem with the device shouldn't it display wrong in every app? for me it only displays like that on my ionic application, in every other application it is displaying right, also, if i put a <input type="date"> in my ionic app, it is showing fine, the only way I see it like this is when I use this plugin.

@tavosansal
Copy link

I agree with @escobar5 ... time picker provided by this plugin looks perfectly fine. The date picker doesn't.

@uzumakinaruto123
Copy link

uzumakinaruto123 commented Feb 23, 2017

Most of of the apps adjust to the changed resolution. If you have any other app using this same date picker , do check in it. Its hard to find some native app with this datepicker. But , check it if you can.
What I am saying is this plugin is just cordova wrapper for native datepicker. For me , on my device if I change dpi to 480 (device deault) then datepicker looks perfect. Now , at 400 it does not. Even I am using it in Ionic. plugin just calls the native java datepicker and gets result back. maybe , I missed something. @VitaliiBlagodir can confirm

@escobar5
Copy link
Author

@uzumakinaruto123 I have the default dpi for my device, also tried with a couple of emulators, same result, <input type="date"> shows the same datepicker, and it shows fine.

@ChadHelbling
Copy link

@uzumakinaruto123 I don't think we should be messing around with a users native pixel density. The pixel densities are different because android supports a wide variety of screen sizes and resolutions. I'm sure the native datepicker is designed to handle that, however it seems there may be some extra work needed to get the plugin to match that functionality.

@uzumakinaruto123
Copy link

uzumakinaruto123 commented Feb 23, 2017

I never tried <input type="date"> . I will try this and check if it opens the same picker and if it looks perfect.

Update :-
@escobar5 I tried it. and it does look perfect. layout is bit different and seems to be of fixed width on every device. but I never knew html input could open it. Maybe plugin will need some extra work.

@allanpoppe
Copy link

Any news on this?

@machty
Copy link

machty commented Dec 25, 2019

This is still an issue. Running an Emulator on API 28, Android 9, and this is what I'm seeing in my app with cordova-plugin-datepicker:

image

And this is what I see when I go into system settings:

image

@machty
Copy link

machty commented Dec 25, 2019

This seems to fix: #244

@VaultDeveloper
Copy link

The fix #244 is from 2017 but never merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants