Skip to content

Commit 4a2d22f

Browse files
committed
Fixed the bug in my run configuration that led me to think ResxChooser didn't work. Added a regression test. Fixes #25
1 parent 1147323 commit 4a2d22f

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

src/main/java/de/vogel612/helper/Main.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public static void main(final String[] args) {
3131
TranslationPresenter tp = new TranslationPresenter();
3232
ResxChooser rc = new ResxChooser();
3333
if (args.length != 0) {
34-
final Path resxFile = Paths.get(args[0]).normalize();
34+
final Path resxFile = Paths.get(args[0]);
3535
rc.setFileset(resxFile);
3636
}
3737

src/main/java/de/vogel612/helper/ui/ResxChooser.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ public ResxChooser() {
118118
}
119119

120120
public void setFileset(Path fileset) {
121-
if (fileset == null) {
122-
throw new IllegalArgumentException();
121+
if (fileset == null || !fileset.toFile().exists()) {
122+
throw new IllegalArgumentException("File does not exist");
123123
}
124124
this.fileset = fileset;
125125
onFilesetChange();

src/test/java/de/vogel612/helper/ui/ResxChooserTests.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,4 +55,10 @@ public void submitButton_withUnselectedPath_doesNothing() {
5555
cut.setFileset(null);
5656
verifyNoMoreInteractions(listener);
5757
}
58+
59+
@Test(expected = IllegalArgumentException.class)
60+
public void setFileset_withInexistantFile_throws() {
61+
cut.setFileset(Paths.get("/", "some", "stupid", "file", "that", "does", "not", "exist.resx"));
62+
verifyNoMoreInteractions(listener);
63+
}
5864
}

0 commit comments

Comments
 (0)