Skip to content
This repository was archived by the owner on Jul 25, 2024. It is now read-only.

Commit 0ef8d3d

Browse files
committed
Add the technical explanation for the pop-up behavior
1 parent e6afbbb commit 0ef8d3d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

public/index.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@
100100
try {
101101
const paymentResponse = await request.show();
102102
} catch (err) {
103+
// See https://source.chromium.org/chromium/chromium/src/+/main:components/payments/core/native_error_strings.cc
103104
if (err instanceof DOMException && err.name === "AbortError") {
104105
switch (err.message) {
105106
case "Another PaymentRequest UI is already showing in a different tab or window.":
@@ -210,10 +211,9 @@
210211
pop-up. Try this multiple times.
211212
</p>
212213
<p>
213-
<b>Explanation:</b> whenever it shows processing on the popup and you
214-
reload at the same time it for some reason detaches into a pop-up. I don't
215-
have the specific details of why this happens, but I will come back with
216-
them soon.
214+
<b>Technical explanation:</b> when the URL is supposed to render to a web
215+
dialog modal view, but instead it falls back to a pop-up when it the web
216+
dialog modal view is destroyed, because it is detached
217217
</p>
218218
</details>
219219
<details>

0 commit comments

Comments
 (0)