-
Notifications
You must be signed in to change notification settings - Fork 12
PROOF OF CONCEPT: a function to write extension functions with warning #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
j-fu
wants to merge
3
commits into
master
Choose a base branch
from
jpt/extension-error-proof-of-concept
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,55 @@ WriteVTK.VTKCellType(::Type{<:Quadrilateral2D}) = VTKCellTypes.VTK_QUAD | |
| WriteVTK.VTKCellType(::Type{<:Tetrahedron3D}) = VTKCellTypes.VTK_TETRA | ||
| WriteVTK.VTKCellType(::Type{<:Hexahedron3D}) = VTKCellTypes.VTK_HEXAHEDRON | ||
|
|
||
| struct ExtensionLoadError <: Exception | ||
| fname::Symbol | ||
| weakdeps::Vector{Symbol} | ||
| end | ||
|
|
||
| Base.showerror(io::IO, e::ExtensionLoadError) = | ||
| print( | ||
| io, | ||
| "ExtensionLoadError: " | ||
| * "The function " * String(e.fname) * " is part of an extension.\n" | ||
| * "Suggestion: Install and load the following modules:" | ||
| * mapreduce(x -> "\n" * x, *, String.(e.weakdeps)) | ||
| ) | ||
|
|
||
| struct ExtensionMethodError <: Exception | ||
| fn::Function | ||
| args::Tuple | ||
| end | ||
|
|
||
|
|
||
| function Base.showerror(io::IO, e::ExtensionMethodError) | ||
| fname = String(nameof(e.fn)) | ||
| argtypes = typeof.(e.args) | ||
| println(io, | ||
| "ExtensionMethodError: no method matching " * fname | ||
| * "(" * join(map(x-> "::"*String(nameof(x)),argtypes),',') | ||
| * ")") | ||
| println(io,"The function " * fname * " exists in a loaded extension," | ||
| *" but no method is defined for this combination of argument types.\n" | ||
| * "\nCandidates are:\n" | ||
| ) | ||
| println.(io, filter(x -> x != which(e.fn, (argtypes...,)), methods(e.fn))) | ||
| return nothing | ||
| end | ||
|
|
||
| function prepare_extension_function(fname::Symbol, weakdeps::Vector{Symbol}, args::Vector{Symbol}) | ||
| expr = quote | ||
| function $fname($(args...); kwargs...) | ||
| if mapreduce(x -> isdefined(Main, x) && isa(getfield(Main,x),Module), &, $weakdeps) | ||
| throw(ExtensionMethodError($fname, ($(args...),))) | ||
| else | ||
| throw(ExtensionLoadError(nameof($fname), $weakdeps)) | ||
| end | ||
| return nothing | ||
| end | ||
| end | ||
| return eval(expr) | ||
| end | ||
|
|
||
| """ | ||
| $(TYPEDSIGNATURES) | ||
|
|
||
|
|
@@ -162,19 +211,11 @@ function simplexgrid(file::String; format = "", kwargs...) | |
| end | ||
|
|
||
| function simplexgrid(file::String, ::Type{Val{:msh}}; kwargs...) | ||
| return try | ||
| simplexgrid_from_gmsh(file) | ||
| catch e | ||
| throw(ErrorException("Missing Gmsh extension. Add Gmsh.jl to your environment and import it to read msh files.")) | ||
| end | ||
| return simplexgrid_from_gmsh(file) | ||
| end | ||
|
|
||
| function simplexgrid(file::String, ::Type{Val{:geo}}; kwargs...) | ||
| return try | ||
| simplexgrid_from_gmsh(file) | ||
| catch e | ||
| throw(ErrorException("Missing Gmsh extension. Add Gmsh.jl to your environment and import it to read geo files.")) | ||
| end | ||
| return simplexgrid_from_gmsh(file) | ||
| end | ||
|
|
||
| function simplexgrid(file::String, ::Type{Val{:sg}}; kwargs...) | ||
|
|
@@ -272,7 +313,11 @@ function simplexgrid(file::String, ::Type{Val{:sg}}; kwargs...) | |
| return g | ||
| end | ||
|
|
||
| function simplexgrid_from_gmsh end | ||
| prepare_extension_function(:simplexgrid_from_gmsh, [:Gmsh], [:filename]) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would prefer to enforce key word arguments here:
|
||
| # function simplexgrid_from_gmsh(filename; incomplete = false, Tc = Float32, Ti = Int32) | ||
| # throw(ErrorException("Missing Gmsh extension. Add Gmsh.jl to your environment and import it to read msh or geo files.")) | ||
| # end | ||
|
|
||
|
|
||
| function simplexgrid_to_gmsh end | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you want to reduce by the operator
&&and not the binary&? I think they behave the same, but&&is clearerThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would but reduce does not like that operator for some reason