From 39d76837cd8f8bad4289190c9c0a69df91cd11df Mon Sep 17 00:00:00 2001
From: Qingxin Wu <qingxinwu@google.com>
Date: Wed, 26 Jul 2023 23:34:48 -0400
Subject: [PATCH 1/2] Fix the wrong service-worker mode.

---
 spec.bs | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/spec.bs b/spec.bs
index 5672769e7..4b244e1d7 100644
--- a/spec.bs
+++ b/spec.bs
@@ -348,8 +348,6 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
   ::  «`Accept`: `application/json`»
   :   [=request/client=]
   ::  `null`
-  :   [=request/service-workers mode=]
-  ::  "`none`"
   :   [=request/origin=]
   ::  |frameOrigin|
   :   [=request/mode=]
@@ -1529,8 +1527,6 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
     ::  «`Accept`: `text/javascript`»
     :   [=request/client=]
     ::  `null`
-    :   [=request/service-workers mode=]
-    ::  "`none`"
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
@@ -1560,8 +1556,6 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
     ::  «`Accept`: `application/wasm`»
     :   [=request/client=]
     ::  `null`
-    :   [=request/service-workers mode=]
-    ::  "`none`"
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
@@ -1599,8 +1593,6 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
     ::  «`Accept`: `application/json`»
     :   [=request/client=]
     ::  `null`
-    :   [=request/service-workers mode=]
-    ::  "`none`"
     :   [=request/mode=]
     ::  "`no-cors`"
     :   [=request/referrer=]
@@ -2622,8 +2614,6 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
       ::  «`Accept`: `application/json`»
       :   [=request/client=]
       ::  `null`
-      :   [=request/service-workers mode=]
-      ::  "`none`"
       :   [=request/mode=]
       ::  "`no-cors`"
       :   [=request/referrer=]

From 7fb52963222fbce24b10aa78cc95741fb7918739 Mon Sep 17 00:00:00 2001
From: Qingxin Wu <qingxinwu@google.com>
Date: Mon, 28 Aug 2023 11:40:31 -0400
Subject: [PATCH 2/2] Add notes about service worker interception.

---
 spec.bs | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/spec.bs b/spec.bs
index 27a637921..34ccda925 100644
--- a/spec.bs
+++ b/spec.bs
@@ -359,6 +359,9 @@ To <dfn>check interest group permissions</dfn> given an [=origin=]
   ::  "`omit`"
   :   [=request/redirect mode=]
   :: "`error`"
+
+  Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+    service worker interceptions, despite not having to set the service workers mode.
 1. Let |resource| be null.
 1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
   [=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
@@ -1538,6 +1541,9 @@ To <dfn>fetch script</dfn> given a [=URL=] |url|:
     ::  "`omit`"
     :   [=request/redirect mode=]
     :: "`error`"
+
+    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+      service worker interceptions, despite not having to set the service workers mode.
   1. Let |script| be null.
   1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
     [=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|
@@ -1567,6 +1573,9 @@ To <dfn>fetch WebAssembly</dfn> given a [=URL=] |url|:
     ::  "`omit`"
     :   [=request/redirect mode=]
     :: "`error`"
+
+    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+      service worker interceptions, despite not having to set the service workers mode.
   1. Let |moduleObject| be null.
   1. [=Fetch=] |request| with [=fetch/processResponseConsumeBody=] set to the following steps given
     a [=response=] |response| and null, failure, or a [=byte sequence=] |responseBody|:
@@ -1604,6 +1613,9 @@ To <dfn>fetch trusted signals</dfn> given a [=URL=] |url|, and a [=boolean=] |is
     ::  "`omit`"
     :   [=request/redirect mode=]
     :: "`error`"
+
+    Issue: One of the side-effects of a `null` client for this subresource request is it neuters all
+      service worker interceptions, despite not having to set the service workers mode.
   1. Let |signals| be null.
   1. Let |dataVersion| be null.
   1. Let |formatVersion| be null.
@@ -2628,6 +2640,9 @@ The <dfn for=Navigator method>updateAdInterestGroups()</dfn> method steps are:
       ::  "`omit`"
       :   [=request/redirect mode=]
       :: "`error`"
+
+      Issue: One of the side-effects of a `null` client for this subresource request is it neuters
+        all service worker interceptions, despite not having to set the service workers mode.
     1. Let |update| be null.
     1. [=Fetch=] |request| with [=fetch/useParallelQueue=] set to true, and
       [=fetch/processResponseConsumeBody=] set to the following steps given a [=response=] |response|