Skip to content

Latest commit

 

History

History
28 lines (16 loc) · 1.45 KB

gh-pr-and-issues.md

File metadata and controls

28 lines (16 loc) · 1.45 KB

GitHub

Issues

If something comes up. A problem. A bug. A feature. Even if you're working on something else. Create an issue in the respective repository.

Pull Requests

What are Pull Requests?

These were created in the open source world outside of git. For example GitHub and BitBucket do these things.

Why do we do Pull Requests?

  • Enable Code Review prior to merging into main.
  • Enable Checking (run CI tests) prior to merging into main which helps catch errors and bugs.

PRs should close issues

if something comes up, it needs to be an issue. even if it's found while working something else. When a PR is submitted, the comments should say "resolves #42, #99" etc.

Read More