Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do List #1

Open
3 of 8 tasks
WaluigiBSOD opened this issue Jan 8, 2024 · 0 comments
Open
3 of 8 tasks

To-do List #1

WaluigiBSOD opened this issue Jan 8, 2024 · 0 comments

Comments

@WaluigiBSOD
Copy link
Owner

WaluigiBSOD commented Jan 8, 2024

Code

  • Not really urgent, but a statement in password.js can be rewritten with bit shifting, mostly to be consistent with fzmv-password-decoder
  • Not really urgent too, but would also be a good idea to remove input clear on mouse click, fits more for just password decoders when a working password has been entered, an idea could be also moving it on right click or double click
  • Replace every instance of multiplication, division or remainder involving powers of 2 with their bit-wise equivalent form
  • _ExistsInKeyboard1D inside keyboard.js has ironically zero purpose to exist, remove it
  • Some calls of _FindOffsetInKeyboard1D in dijkstra.js, generator.js, and keyboard.js can be replaced with constants
  • In password.js the check ((((Buffer[ElementX] & (1 << BitX)) >> BitX) + ((Buffer[ElementY] & (1 << BitY)) >> BitY)) & 0x1) can be rewritten as just (((Buffer[ElementX] & (1 << BitX)) >> BitX) ^ ((Buffer[ElementY] & (1 << BitY)) >> BitY))

Repository

  • Add a player name example in readme
  • Expand the readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant