feat: fixed audience counter permission problem #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmily7829
requested changes
Oct 19, 2023
Comment on lines
44
to
47
| val userRoles = member?.roles?.map { it.id } ?: emptyList() | ||
| val requiredRole = wsa.wsaAlphaRoleId | ||
|
|
||
| reply("counter start!!!").queue { | ||
| scheduledRecordHighestAudience(startRecordTime, endRecordTime) | ||
| if (userRoles.contains(requiredRole)) { |
There was a problem hiding this comment.
- 從
Member取出的Id列表應該是memberRoleIds wsa.wsaAlphaRoleId已經是具有意義的屬性，可以不用再包成一個變數- 可以再思考這三行程式碼能不能再簡化成更語意化的方法
...nce-counter/src/main/kotlin/tw/waterballsa/utopia/audiencecounter/AudienceCounterListener.kt
Outdated
Show resolved
Hide resolved
...nce-counter/src/main/kotlin/tw/waterballsa/utopia/audiencecounter/AudienceCounterListener.kt
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
m1a2st
requested changes
Oct 22, 2023
Comment on lines
+49
to
+51
| val currentTime = now() | ||
| val startRecordTime = currentTime.truncatedTo(ChronoUnit.MINUTES).toDate() | ||
| val endRecordTime = currentTime.plusMinutes(recordPeriodTime).toDate() |
There was a problem hiding this comment.
Nit： 把 currentTime 、 startRecordTime 、 endRecordTime 封裝成一個具有領域意義類別，程式會更乾淨整潔
請參考 message-cherry-pick 的 DateTimeRange。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why need this change? / Root cause:
The counter command should be used by Alpha.
Changes made:
Test Scope / Change impact:
if user is Alpha -> run the counter
if user isn't Alpha -> tell the user "You should be the Alpha."