Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css divider #10

Open
AldoFerrari opened this issue Jan 23, 2014 · 3 comments
Open

css divider #10

AldoFerrari opened this issue Jan 23, 2014 · 3 comments

Comments

@AldoFerrari
Copy link
Contributor

add divider-vertical and divider-horizontal who where dropped in bootstrap 3 but still useful

@andymcfee
Copy link
Contributor

The divider's were removed from bootstrap because the "dividers" can easily be made with a 1px border. See: twbs/bootstrap#9501

I would argue that the inclusion of a divider is a "design" decision and therefore should not be built into the core framework. If we want it to be part of the base design, then we can do that (and I think it wouldn't be a bad idea), but I don't think it should be an element per say (i.e. <li class="divider"></li>)

@AldoFerrari
Copy link
Contributor Author

let's go with it as you suggested "part of the base design"

@sandorfr
Copy link

sandorfr commented Sep 4, 2014

I'm not sure about divider-vertical. But it would be great to have a divider not only working with dropdowns but with navbars too (like it appears to be the case in foundation). I don't think it is just a 1px border. It is a 1px border which depends on the orientation of the surrounding li which might be altered by a media query.

But after reading the other thread, I don't think we'll see something happen soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants