From 99497cf742394461fba50e224f5f57601381b2d1 Mon Sep 17 00:00:00 2001 From: Manpreet Date: Thu, 13 Apr 2017 17:03:33 +0200 Subject: [PATCH 1/3] added new option in variant type plusPage and disabled unused variants --- web/static/js/variantpayloadoptions.es6 | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/web/static/js/variantpayloadoptions.es6 b/web/static/js/variantpayloadoptions.es6 index c9ab488..a525a31 100644 --- a/web/static/js/variantpayloadoptions.es6 +++ b/web/static/js/variantpayloadoptions.es6 @@ -233,6 +233,7 @@ const options = { } }, signupFormPlanSelectorType: { + disabled: true, name: 'Singup Form - Plan Selector Type', key: 'signupFormPlanSelectorType', defaults: { @@ -261,6 +262,7 @@ const options = { } }, helpPageType: { + disabled: true, name: 'Help Page Type', key: 'helpPageType', defaults: { @@ -319,6 +321,13 @@ const options = { field: 'type', value: 'socialProof' } + }, + ctaText: { + type: 'string', + requiredWhen: { + field: 'type', + value: 'bannerWithCTA' + } } }, properties: [ @@ -328,7 +337,8 @@ const options = { type: 'string', enum: [ {label: 'none', value: 'none'}, - {label: 'Social Proof', value: 'socialProof'} + {label: 'Social Proof', value: 'socialProof'}, + {label: 'Banner with CTA', value: 'bannerWithCTA'} ] }, { @@ -342,6 +352,10 @@ const options = { { key: 'by', title: 'By' + }, + { + key: 'CTA Text', + title: 'ctaText' } ] } From a9d260ede59b2bd913c0aa8b7867a790d41e3721 Mon Sep 17 00:00:00 2001 From: Manpreet Date: Thu, 13 Apr 2017 18:04:39 +0200 Subject: [PATCH 2/3] swapped key with title --- web/static/js/variantpayloadoptions.es6 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/static/js/variantpayloadoptions.es6 b/web/static/js/variantpayloadoptions.es6 index a525a31..8d08837 100644 --- a/web/static/js/variantpayloadoptions.es6 +++ b/web/static/js/variantpayloadoptions.es6 @@ -354,8 +354,8 @@ const options = { title: 'By' }, { - key: 'CTA Text', - title: 'ctaText' + key: 'ctaText', + title: 'CTA Text' } ] } From 4e166e8f6fd422003fd2e774f10b51b578d327ee Mon Sep 17 00:00:00 2001 From: Manpreet Date: Fri, 14 Apr 2017 10:47:52 +0200 Subject: [PATCH 3/3] added onPage attribute --- web/static/js/variantpayloadoptions.es6 | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/web/static/js/variantpayloadoptions.es6 b/web/static/js/variantpayloadoptions.es6 index 8d08837..44c0d78 100644 --- a/web/static/js/variantpayloadoptions.es6 +++ b/web/static/js/variantpayloadoptions.es6 @@ -328,6 +328,13 @@ const options = { field: 'type', value: 'bannerWithCTA' } + }, + onPage: { + type: 'string', + requiredWhen: { + field: 'type', + value: 'bannerWithCTA' + } } }, properties: [ @@ -356,7 +363,17 @@ const options = { { key: 'ctaText', title: 'CTA Text' - } + }, + { + key: 'onPage', + title: 'Page', + type: 'string', + enum: [ + {label: 'none', value: 'none'}, + {label: 'Plus', value: '/plus'}, + {label: 'Sign-in', value: '/sign-in'} + ] + }, ] } },