Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag-and-drop breaks when selecting too many auras #4578

Closed
2 tasks done
Elitesparkle opened this issue Aug 22, 2023 · 2 comments
Closed
2 tasks done

Drag-and-drop breaks when selecting too many auras #4578

Elitesparkle opened this issue Aug 22, 2023 · 2 comments
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@Elitesparkle
Copy link

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

After selecting multiple auras, I used drag-and-drop to insert them in a group.

Here is what happened to those auras:

  • some of them correctly appeared in the group;
  • a couple of them appeared in the group of a completely different aura;
  • some of them have been lost, deleted.

After that, the game was still showing the drag-and-drop animation, but said animation was frozen.

The bug happened while workin on my Cooldown Timeline (Shaman) aura.

WeakAuras Version

5.7.0

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

  • Yes

Lua Error

1x WeakAurasOptions/WeakAurasOptions.lua:948: script ran too long
[string "@WeakAurasOptions/WeakAurasOptions.lua"]:948: in function <WeakAurasOptions/WeakAurasOptions.lua:946>
[string "@WeakAurasOptions/WeakAurasOptions.lua"]:957: in function <WeakAurasOptions/WeakAurasOptions.lua:946>
[string "@WeakAurasOptions/WeakAurasOptions.lua"]:1149: in function `SortDisplayButtons'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:923: in function `func'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:1328: in function `Expand'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:1363: in function `EnableExpand'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:528: in function `UpdateExpandButton'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:342: in function `Ungroup'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:367: in function `func'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:1206: in function `Drop'
[string "@WeakAurasOptions/WeakAurasOptions.lua"]:1456: in function `Drop'
[string "@WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua"]:800: in function <...eGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:796>

Locals:
button = <table> {
 thumbnailType = "icon"
 GetData = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1317
 GetOffset = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1268
 Expand = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1320
 UpdateOffset = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1255
 UpdateViewTexture = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1526
 icon = Texture {
 }
 GetExpanded = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1351
 ReleaseThumbnail = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1597
 IsDragging = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1218
 SetNormalTooltip = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:966
 title = FontString {
 }
 SetIds = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1292
 IsEnabled = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1561
 SetData = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1313
 SetTitle = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1274
 orgIcon = Frame {
 }
 OverrideIcon = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1650
 callbacks = <table> {
 }
 DragReset = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1221
 data = <table> {
 }
 RecheckVisibility = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1498
 DropEnd = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1224
 SetIcon = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1633
 downgroup = Button {
 }
 warning = Button {
 }
 SetOnExpandCollapse = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1348
 IsGroup = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1310
 titletext = "Challenging Shout - Cooldown Timeline (Warrior)"
 Collapse = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1334
 frame = WeakAurasDisplayButton1016 {
 }
 EnableExpand = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1360
 EnableLoaded = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1422
 Enable = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1549
 ShowTooltip = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1253
 iconRegion = Frame {
 }
 thumbnail = Frame {
 }
 DisableLoaded = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1417
 StopGrouping = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1060
 PriorityShow = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1465
 DragStart = <function> defined @WeakAurasOptions/AceGUI-Widgets/AceGUIWidget-WeakAurasDisplayButton.lua:1134

Reproduction Steps

  1. Have a group with more than 60 auras in it.
  2. Create another group within that group.
  3. Select all auras within the main group.
  4. Drag-and-drop the selected auras in the secondary group.

Last Good Version

No response

Screenshots

image

Export String

No response

@Elitesparkle Elitesparkle added the 🐛 Bug This is a problem with WeakAuras. label Aug 22, 2023
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Aug 22, 2023
@mrbuds
Copy link
Contributor

mrbuds commented Aug 22, 2023

Thanks for the report

Can you include your data,
Then specify exactly which auras you have selected and where you move them?

We need to be able to reproduce the problem with your settings

@Elitesparkle
Copy link
Author

Elitesparkle commented Aug 22, 2023

Sure! My data: WeakAuras.zip

To reproduce the issue when using that version of my data:

  1. Expand the "Cooldown Timeline (Shaman)" group.
  2. Expand the "Cooldown Icons - Cooldown Timeline (Shaman)" group.
  3. Use [Shift] to select all 60-61 auras that are within that group.
  4. Drag-and-drop them from the inner group to the outer group.

The bug happens even when moving them from a outer group to an inner one.

InfusOnWoW added a commit to InfusOnWoW/WeakAuras2 that referenced this issue Sep 9, 2023
We should be using more corotinues to make these mass edits safer in the
presence of wow's time limits on processing.

Although the user better not interact with the interface while the
coroutine runs.

Fixes: WeakAuras#4578
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

2 participants