Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spell cast succeeded trigger can eat additional spell ids #5361

Closed
1 task done
emptyrivers opened this issue Aug 29, 2024 · 0 comments
Closed
1 task done

spell cast succeeded trigger can eat additional spell ids #5361

emptyrivers opened this issue Aug 29, 2024 · 0 comments
Labels
🐛 Bug This is a problem with WeakAuras.

Comments

@emptyrivers
Copy link
Contributor

emptyrivers commented Aug 29, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

i didn't bother to look at what the behavior of a trigger with this bug is, but the trigger's spellId array does have a hole where it probably shouldn't:

{
    ["actions"] = {
        ["finish"] = {
        },
        ["init"] = {
        },
        ["start"] = {
        },
    },
    ["adjustedMax"] = "",
    ["adjustedMin"] = "",
    ["alpha"] = 1,
    ["anchorFrameType"] = "SCREEN",
    ["anchorPoint"] = "CENTER",
    ["animation"] = {
        ["finish"] = {
            ["duration_type"] = "seconds",
            ["easeStrength"] = 3,
            ["easeType"] = "none",
            ["type"] = "none",
        },
        ["main"] = {
            ["duration_type"] = "seconds",
            ["easeStrength"] = 3,
            ["easeType"] = "none",
            ["type"] = "none",
        },
        ["start"] = {
            ["duration_type"] = "seconds",
            ["easeStrength"] = 3,
            ["easeType"] = "none",
            ["type"] = "none",
        },
    },
    ["authorOptions"] = {
    },
    ["color"] = {
        [1] = 1,
        [2] = 1,
        [3] = 1,
        [4] = 1,
    },
    ["conditions"] = {
        [1] = {
            ["changes"] = {
                [1] = {
                    ["property"] = "desaturate",
                    ["value"] = true,
                },
            },
            ["check"] = {
                ["checks"] = {
                    [1] = {
                        ["trigger"] = 1,
                        ["value"] = 0,
                        ["variable"] = "show",
                    },
                    [2] = {
                        ["trigger"] = 2,
                        ["value"] = 1,
                        ["variable"] = "onCooldown",
                    },
                },
                ["trigger"] = -2,
                ["variable"] = "AND",
            },
        },
        [2] = {
            ["changes"] = {
                [1] = {
                    ["property"] = "color",
                    ["value"] = {
                        [1] = 0.47450983524323,
                        [2] = 0.5137255191803,
                        [3] = 1,
                        [4] = 1,
                    },
                },
            },
            ["check"] = {
                ["op"] = "<",
                ["trigger"] = 2,
                ["value"] = 1,
                ["variable"] = "insufficientResources",
            },
        },
    },
    ["config"] = {
    },
    ["cooldown"] = true,
    ["cooldownEdge"] = true,
    ["cooldownSwipe"] = true,
    ["cooldownTextDisabled"] = true,
    ["desaturate"] = false,
    ["displayIcon"] = "",
    ["frameStrata"] = 1,
    ["height"] = 36,
    ["icon"] = true,
    ["iconSource"] = -1,
    ["id"] = "Warlock - Demonology - Summon Demonic Tyrant",
    ["information"] = {
    },
    ["internalVersion"] = 75,
    ["inverse"] = false,
    ["keepAspectRatio"] = true,
    ["load"] = {
        ["class"] = {
            ["multi"] = {
            },
        },
        ["class_and_spec"] = {
            ["single"] = 266,
        },
        ["size"] = {
            ["multi"] = {
            },
        },
        ["spec"] = {
            ["multi"] = {
            },
        },
        ["talent"] = {
            ["multi"] = {
                [125850] = true,
            },
        },
        ["use_class_and_spec"] = true,
        ["use_dragonriding"] = false,
        ["use_never"] = false,
        ["use_petbattle"] = false,
        ["use_talent"] = false,
        ["use_vehicleUi"] = false,
    },
    ["parent"] = "SpinningPlates",
    ["progressSource"] = {
        [1] = -1,
        [2] = "",
    },
    ["regionType"] = "icon",
    ["selfPoint"] = "CENTER",
    ["subRegions"] = {
        [1] = {
            ["type"] = "subbackground",
        },
        [2] = {
            ["glow"] = false,
            ["glowBorder"] = false,
            ["glowColor"] = {
                [1] = 1,
                [2] = 1,
                [3] = 1,
                [4] = 1,
            },
            ["glowDuration"] = 1,
            ["glowFrequency"] = 0.25,
            ["glowLength"] = 10,
            ["glowLines"] = 8,
            ["glowScale"] = 1,
            ["glowThickness"] = 1,
            ["glowType"] = "Proc",
            ["glowXOffset"] = 0,
            ["glowYOffset"] = 0,
            ["type"] = "subglow",
            ["useGlowColor"] = false,
        },
        [3] = {
            ["anchorXOffset"] = 0,
            ["anchorYOffset"] = 0,
            ["rotateText"] = "NONE",
            ["text_anchorPoint"] = "CENTER",
            ["text_automaticWidth"] = "Auto",
            ["text_color"] = {
                [1] = 1,
                [2] = 1,
                [3] = 1,
                [4] = 1,
            },
            ["text_fixedWidth"] = 64,
            ["text_font"] = "Expressway",
            ["text_fontSize"] = 20,
            ["text_fontType"] = "OUTLINE",
            ["text_justify"] = "CENTER",
            ["text_selfPoint"] = "AUTO",
            ["text_shadowColor"] = {
                [1] = 0,
                [2] = 0,
                [3] = 0,
                [4] = 1,
            },
            ["text_shadowXOffset"] = 0,
            ["text_shadowYOffset"] = 0,
            ["text_text"] = "%p",
            ["text_text_format_p_format"] = "timed",
            ["text_text_format_p_time_dynamic_threshold"] = 10,
            ["text_text_format_p_time_format"] = 0,
            ["text_text_format_p_time_legacy_floor"] = false,
            ["text_text_format_p_time_mod_rate"] = true,
            ["text_text_format_p_time_precision"] = 1,
            ["text_visible"] = true,
            ["text_wordWrap"] = "WordWrap",
            ["type"] = "subtext",
        },
        [4] = {
            ["anchorXOffset"] = 0,
            ["anchorYOffset"] = 0,
            ["rotateText"] = "NONE",
            ["text_anchorPoint"] = "TOP",
            ["text_automaticWidth"] = "Auto",
            ["text_color"] = {
                [1] = 1,
                [2] = 0.88627457618713,
                [3] = 0.76862752437592,
                [4] = 1,
            },
            ["text_fixedWidth"] = 64,
            ["text_font"] = "Expressway",
            ["text_fontSize"] = 18,
            ["text_fontType"] = "OUTLINE",
            ["text_justify"] = "CENTER",
            ["text_selfPoint"] = "AUTO",
            ["text_shadowColor"] = {
                [1] = 0,
                [2] = 0,
                [3] = 0,
                [4] = 1,
            },
            ["text_shadowXOffset"] = 0,
            ["text_shadowYOffset"] = 0,
            ["text_text"] = "%1.stacks",
            ["text_text_format_1.stacks_format"] = "none",
            ["text_text_format_2.spellCount_format"] = "none",
            ["text_text_format_s_format"] = "none",
            ["text_visible"] = false,
            ["text_wordWrap"] = "WordWrap",
            ["type"] = "subtext",
        },
    },
    ["triggers"] = {
        [1] = {
            ["trigger"] = {
                ["debuffType"] = "HELPFUL",
                ["duration"] = "15",
                ["event"] = "Spell Cast Succeeded",
                ["names"] = {
                },
                ["spellId"] = {
                    [1] = 265187,
                    [3] = 1,
                },
                ["spellIds"] = {
                },
                ["subeventPrefix"] = "SPELL",
                ["subeventSuffix"] = "_CAST_START",
                ["type"] = "event",
                ["unit"] = "player",
                ["use_spellId"] = true,
                ["use_unit"] = true,
            },
            ["untrigger"] = {
            },
        },
        [2] = {
            ["trigger"] = {
                ["auranames"] = {
                    [1] = "267171",
                },
                ["debuffType"] = "HELPFUL",
                ["event"] = "Cooldown Progress (Spell)",
                ["genericShowOn"] = "showAlways",
                ["names"] = {
                },
                ["ownOnly"] = true,
                ["spellIds"] = {
                },
                ["spellName"] = 264119,
                ["subeventPrefix"] = "SPELL",
                ["subeventSuffix"] = "_CAST_START",
                ["type"] = "spell",
                ["unit"] = "pet",
                ["useName"] = true,
                ["use_genericShowOn"] = true,
                ["use_spellName"] = true,
                ["use_track"] = true,
            },
            ["untrigger"] = {
            },
        },
        ["activeTriggerMode"] = -10,
        ["disjunctive"] = "any",
    },
    ["uid"] = "DAeMYxODYyC",
    ["useAdjustededMax"] = false,
    ["useAdjustededMin"] = false,
    ["useCooldownModRate"] = true,
    ["width"] = 48,
    ["xOffset"] = 0,
    ["yOffset"] = 0,
    ["zoom"] = 0.3,
}

WeakAuras Version

tip of main branch

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

US/NA

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

No response

Reproduction Steps

  1. create an other events -> spell cast succeeded trigger
  2. enable the spell id option
  3. add at least 3 spell ids
  4. remove the second spell id

Expected:

2nd spell id is removed, 3rd+ move up one step to take its place.

Actual:

All but the first spell id will appear to vanish. Adding a second spell id will revive the 3rd+ spell ids in the UI.

Last Good Version

No response

Screenshots

Export String

!WA:2!1zXZVTXs54ULwj)KAt971O0hvVNjIg9AvjQXqtVGuLTJtBcPXM1onTqPEND3X7onRNzEZmRt87uRPhIaXfFHYdozXr4Ipaxr5aNhz9oJqfjesWP(xaFZS2jQpLMdXFFFZ3V)5MBJcDlewi8OBoIeWOnzPIa81NBmk8fPsfo8rOdp3Pie65e9R3PJeRYngrdIzIgmcv5xT2oTQ5ojGXsczhqBEaHJ9oEgATWiSNafOimQCnxPcju597qOezC(kWpQ8ducsuewiF(YIPG)9kQ(CSlUhMQesoojzZWlT45)O)1fDERm13sVzANoKdh3UA5MTA3Svz3wdctfiJHwA17QNN)jnncwSksQk2mniaJdXHvsbt6Ztq9XIXPsC7PA3BWuazExkQlwM)ed1qGbd52SrTT3EGreJk8gfI9bpOf4NIhwB7gBS72dtPt9)8lRV0rZp0QYDaTT45V4FvFzxlUUG(JhIap1AMp1V0A3B17TQaYv1Pj994xXyIimflibnJzhuN6n59qhjHFkNCaQVu)D1xxVqjown5KyXypp91YlakzWZZVw1PLJIneSibwkl(f2SZn1FA(HgrvqnAFp9NP)CDX8JdjYxKsHIwpCjeTp)kilCRSO7rSq8FAU3bfFSGIsEmu6GK(V9D7JX8YGpeOCnLbVHsCshBtI(cq6sIuM6doEeKzDXrMoITwqF5jaQpy9iblLg(VNeLWoydb(ltX0G(no)DwP0D1xwamzE4yZ)wFAD2zGbZucQaXvWid22yAKk(QJnWpDA)6qdsvwctSLd83Xqa)GzuITC(KPCAnERysW(uij5yfSzakb7uXagBjSnbE8kwRvHjcXI4JUg)7PWhQAB)xhMOls1M3wr6IBZf4aIjb5m8eww6gCEXpKaDzHTn5jV3AF8KKyLY72Qo)JTerPkgicjypsOkUsza9DzQICio0s8v8V)hYcj4iuq)2Dsyq8FSLbZuoPtFOqjykW4TaIv2P(o14x7m0sgGRrzHz1gZ7tYwlmlxoYktWjP9Ht1bvnQ2HCtti0cZlKfKXOWtRcVhXzfXjNiUDMR(UT2EZDQLr9aOmSNaXhS3uGSGQhK39tWE85ZsANU1sFb(N9HYozy5MkuMtK18KlxoNtDJMKVcFt(n)qQjSpmGtcARIHqngg)U608ZSa6Of0pn3zKELtbQqzuS(bdVXQRaRnd2xQ9TEGEt9w6FIEB9JELgNtxxFbDd9pvFzDl9J3Y5H3))9SN9Y5MBUhE))ZBEZFdaC07PFI(NLt)l0px3ow7vQv9g6FU(zNrdsPvS7qQctIZOPJ0b3qVBUZOHDMJDcN(XysuSAZkjmu4FXUtc2n5JuQeCSDpdfwPkI9vWifvTGB30efzHfZ9F)AVkMnhlO)Y8JS7JSmeZN3GekqrmQGesOrXwT2ddZOj4DjXVnibjLqTnSTvb(sGPe8FCEx7dgfYlye595dmhu(SVAmr5PN5Sx9IFxwHAdbS(00S53SQBTA78T5KqJhjS7XSRGmhr1V0BmHMLoa65hb0cj2JF3Az3GyCW(RPV0TNBqpKGGGEZsL3zDFlD5TGxC0VUIz9UBpuskohq57OF9igD2(B9roIGyencUCSS(iVbCbdggu91)OL1)YnGNxIXl8JTIXVkHknhjdiqQ0flTh4L6FLrYTE49)hp)5z9j)to3a44O)1U2XvXHtBr1)g7KBPus441lJF0tpS(6pTFv(Nm78UznX6ePjsc9S55zEkCKW1SeBKIf0l7cXI5(ZJxIeYV9Eircly)I)GIRJ7YOGjJ6dint7cyz0ibfB1hUrcNss4XiNXDmfJMWzkfYX9aZco0qeLKLNxtNFJJXiPHb7()lcJdrtM99aTnFnHqInfd5adFMcMoQsxeHUH(3z5w)16FV(pa)(rFBk(GCDir5feQjsWXtG1Vq)rDUTWMVYxXyDB4CNv(HMdNMVTytqIZnywsY7T8PxDZ(gRBD95oxbzP1X9k07BEY))d

Bisector Report

No response

@emptyrivers emptyrivers added the 🐛 Bug This is a problem with WeakAuras. label Aug 29, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Aug 29, 2024
@emptyrivers emptyrivers removed the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Aug 29, 2024
mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Aug 29, 2024
mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

1 participant