Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive Talent doesn't work for "spell known" load option when not using spellID #5405

Closed
1 task done
CrystalBearer opened this issue Sep 9, 2024 · 11 comments
Closed
1 task done
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@CrystalBearer
Copy link

CrystalBearer commented Sep 9, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

In the "Load" tab, in order to enter a spell known, one must use the SpellID, as it does not seem to validate spell names of passive spells.

WeakAuras Version

5.17.1

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

US/NA

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

No response

Reproduction Steps

Go to any aura.
Select "Load"
Attempt to add a passive spell by name as conditional.

Last Good Version

n/a

Screenshots

No response

Export String

No response

Bisector Report

No response

@CrystalBearer CrystalBearer added the 🐛 Bug This is a problem with WeakAuras. label Sep 9, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Sep 9, 2024
@InfusOnWoW
Copy link
Contributor

Hero Talents can and are different per spec. so that does not work.

Usually the Spell Known load option is the better choice anyway.

@CrystalBearer
Copy link
Author

CrystalBearer commented Sep 9, 2024

Hero Talents can and are different per spec. so that does not work.

Then, if you have multiple 'specs' chosen, could you have the hero talent options from each of them appear separately for OR selection?

Usually the Spell Known load option is the better choice anyway.

"Spell Known" doesn't work if there is no spell. For example, using a WA to track the stacks of Bloodseeker Vines on a target can't do this because it's a proc from a passive talent. And you can't use "Spell Known" with the passive.

@mrbuds
Copy link
Contributor

mrbuds commented Sep 9, 2024

And you can't use "Spell Known" with the passive.

yes you can

@CrystalBearer
Copy link
Author

CrystalBearer commented Sep 9, 2024

yes you can

Ok. I'm trying it actively as we're talking. I must be missing how since I use this all the time on other auras and have never gotten it to validate on passives. In this case, the passive is "Thriving Growth". It's not validating for me.

@mrbuds
Copy link
Contributor

mrbuds commented Sep 9, 2024

WowB_2024-09-10_01-33-44.mp4

@CrystalBearer
Copy link
Author

So, unlike active spells, you can add them, but only by SpellID? I mean, that's fine, so long as I know that's what I have to do.

@CrystalBearer
Copy link
Author

CrystalBearer commented Sep 9, 2024

Plus... I will have to figure out how to get that on my tooltip or I'll be on WoWhead constantly....

EDIT: Or, I can link the ability into it.

@mrbuds
Copy link
Contributor

mrbuds commented Sep 9, 2024

Get IdTip addon

@CrystalBearer
Copy link
Author

Thanks. Will do. Sorry I needed a video for that; I appreciate the time.

I suppose I would flex this, then, to attempt validation for passive spells as well by name, if possible.

@mrbuds
Copy link
Contributor

mrbuds commented Sep 9, 2024

I couldn't use the name for passive spell as spell known, i reopen ticket for this

@mrbuds mrbuds reopened this Sep 9, 2024
@mrbuds mrbuds changed the title Hero Talents Passive Talent doesn't work for "spell known" load option when not using spellID Sep 9, 2024
@CrystalBearer
Copy link
Author

I couldn't use the name for passive spell as spell known, i reopen ticket for this

Sounds good; thanks. I updated the main post to match this request for easier reference.

mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

No branches or pull requests

3 participants