Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aura_env.saved is wiped on aura reimport #5520

Closed
1 task done
lootwant opened this issue Nov 4, 2024 · 2 comments · Fixed by #5522
Closed
1 task done

aura_env.saved is wiped on aura reimport #5520

lootwant opened this issue Nov 4, 2024 · 2 comments · Fixed by #5522
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.

Comments

@lootwant
Copy link

lootwant commented Nov 4, 2024

Is there an existing issue for this?

  • I have searched the existing open and closed issues.

Description

On aura reimport it's aura_env.saved is apparently wiped. There is no mention of such behaviour in the docs, and it kinda defeats the purpose of persistent local storage.

If it's by design, it would be great to mention it in the docs.
If a hard wipe is not actually required, would be great to make it optional and disabled by default. A checkbox on import along with the others, "Erase saved data"

WeakAuras Version

5.17.4

World of Warcraft Flavor

Retail (Default)

World of Warcraft Region

EU

Tested with only WeakAuras

I got this issue with only WeakAuras enabled

Lua Error

No response

Reproduction Steps

Reimport an aura that has aura_env.saved populated. Observe the nil after reimport instead of saved data.

Last Good Version

No response

Screenshots

No response

Export String

No response

Bisector Report

No response

@lootwant lootwant added the 🐛 Bug This is a problem with WeakAuras. label Nov 4, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Nov 4, 2024
emptyrivers added a commit to emptyrivers/WeakAuras2 that referenced this issue Nov 4, 2024
the problem was actually that `type(ignoredForDiffChecking) == table`
always evals as false, because type(...) returns a string value and
table is the std table library! Whoopsie :)

Fixes WeakAuras#5520
InfusOnWoW pushed a commit that referenced this issue Nov 4, 2024
the problem was actually that `type(ignoredForDiffChecking) == table`
always evals as false, because type(...) returns a string value and
table is the std table library! Whoopsie :)

Fixes #5520
@InfusOnWoW
Copy link
Contributor

The intended behaviour is that saved is not overwritten on update, that was a thus a bug.

@lootwant
Copy link
Author

lootwant commented Nov 5, 2024

Tested, confirming the fix. Ty ty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. 🐛 Bug This is a problem with WeakAuras.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants