Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphics to the latest state of the design system #7

Open
Dierk opened this issue Oct 17, 2022 · 7 comments
Open

Update graphics to the latest state of the design system #7

Dierk opened this issue Oct 17, 2022 · 7 comments

Comments

@Dierk
Copy link
Member

Dierk commented Oct 17, 2022

wait for "go" from @affolter

@affolter
Copy link
Collaborator

So cool to see the progress on Kolibri. I have also made some small steps. I updated the basis for the "new" design. The naming and also colors match with Figma. It is located in the " design-updates " branch.

@Dierk
Copy link
Member Author

Dierk commented Oct 19, 2022

cool. The branch is merged onto main and pushed. I now consider updating the overview page that lists and uses all the design elements.
We can now either delete the design-updates branch or keep it open for future work (in which case we have to rebase the branch before applying more changes).

@Dierk
Copy link
Member Author

Dierk commented Oct 19, 2022

update
src/examples/style/styleOverview.html
src/examples/style/useStyles.js

@Dierk
Copy link
Member Author

Dierk commented Oct 19, 2022

I wonder if in


we should define accentColor etc. in terms of primaryAccent etc.

@affolter
Copy link
Collaborator

I wonder if in

we should define accentColor etc. in terms of primaryAccent etc.

Very good and interesting point. For simplicity and unity, you are right. In terms of Kolibri the accentColor as primaryAccent will work for our cases. I was thinking about a situation in which you would actually like to have a separate variable like accentColor. Let's say normally accentColor is equal primaryAccent but what if the primaryAccent doesn't work visually in a specific situation?

But I am happy with your suggestion as well.

@Dierk
Copy link
Member Author

Dierk commented Oct 19, 2022

the new colors are now visible under https://webengineering-fhnw.github.io/Kolibri/src/examples/style/styleOverview.html

I guess we should also show the fonts in a similar way.

@affolter
Copy link
Collaborator

affolter commented Oct 19, 2022

the new colors are now visible under https://webengineering-fhnw.github.io/Kolibri/src/examples/style/styleOverview.html

I guess we should also show the fonts in a similar way.

Nice, that's cool. Yes, the fonts would be useful also. I wish I could help you, but I could only help on Sunday at earliest this week :-/

Dierk pushed a commit that referenced this issue Oct 20, 2022
Dierk pushed a commit that referenced this issue Oct 20, 2022
…erview.html. Some decisions to be taken, e.g. about opacity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants