Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List optional dependencies in peerDependencies + peerDependenciesMeta #249

Open
moshest opened this issue Nov 15, 2023 · 3 comments
Open

Comments

@moshest
Copy link

moshest commented Nov 15, 2023

For example in package.json:

{
  "name": "linkedom",
  "version": "0.16.1",
  "peerDependencies": {
    "canvas": ">= 2",
  },
  "peerDependenciesMeta": {
    "canvas": {
      "optional": true
    }
  }
}

Please see docs here: https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta

@WebReflection
Copy link
Owner

this "smells like a PR" 😄

@jlara005
Copy link

When is a fix for the warnings going to be released? I'm on latest 0.18.5

WARNING in ./node_modules/linkedom/commonjs/perf_hooks.cjs 3:24-45
Module not found: Error: Can't resolve 'perf_hooks' in 'C:\Dev\TestProject\node_modules\linkedom\commonjs'
@ ./node_modules/linkedom/cjs/interface/document.js 2:22-62
@ ./node_modules/linkedom/cjs/index.js 3:30-64

@WebReflection
Copy link
Owner

When is a fix for the warnings going to be released?

When the PR lands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants