[WIP] added retrofit for edudashboard and outreach #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi i think this way we will be able to solve the bug but this is not a good coding practice to do this. Best way will be to use the same methods and modify the BaseUrl. I think Koin Scope API can help us achieve that. I will also research a little more and get back. |
|
I will not recommend to proceed with this method for now. |
Okay @ujjwalagrawal17 . |
mistervaibhav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/apps-android-wikiedudashboard/blob/master/CONTRIBUTING.md#pull-request-process
What this PR does
Fixes #274
This PR depicts the initial steps in an attempt to resolve the issue regarding fixed base URL.
I think the issue can be resolved by using multiple retrofit objects, each corresponding to education dashboard, outreach, and commons. This would also require separate classes for the respective APIs in the network directory.
@ujjwalagrawal17 kindly tell me if I am approaching this the right way and how may I proceed further.
Thanks.