Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from MVP to MVVM architecture. #50

Open
ujjwalagrawal17 opened this issue Aug 26, 2019 · 7 comments
Open

Migrate from MVP to MVVM architecture. #50

ujjwalagrawal17 opened this issue Aug 26, 2019 · 7 comments
Labels
code-quality enhancement new feature or request high-priority

Comments

@ujjwalagrawal17
Copy link
Member

Describe the feature you'd like

Advantages of using MVVM: https://www.youtube.com/watch?v=FrteWKKVyzI&t=874s
@ujjwalagrawal17
Copy link
Member Author

More references:

  1. https://www.youtube.com/watch?v=FrteWKKVyzI
  2. https://www.youtube.com/watch?v=pErTyQpA390
  3. https://www.youtube.com/watch?v=Qxj2eBmXLHg

@ujjwalagrawal17
Copy link
Member Author

@ShridharGoel can you help us in dividing this issue into small parts. We can start with maybe 1 fragment.

@ShridharGoel
Copy link
Collaborator

@ujjwalagrawal17 Yes, sure.

@ujjwalagrawal17 ujjwalagrawal17 pinned this issue Oct 20, 2019
@ujjwalagrawal17 ujjwalagrawal17 added high-priority enhancement new feature or request and removed enhancement labels Dec 15, 2019
@victorvicari
Copy link
Collaborator

Perhaps add one more layer, and use it for the Repository Pattern

@victorvicari
Copy link
Collaborator

And create some sort of Use Case, between the Repository and View Model, to better / cleaner deal with data / changes, if it's necessary.

@victorvicari
Copy link
Collaborator

To further improvements, remove the view / view bindings from activity / fragment classes.

@gconnect
Copy link
Collaborator

gconnect commented Jan 6, 2020

Replace the Presenters with ViewModels
Replace the RetrofitProviders with Repository
Remove the View binding interfaces where needed replace with data classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality enhancement new feature or request high-priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ujjwalagrawal17 @gconnect @ShridharGoel @victorvicari