helpful-variable doesn't show a "Global Values" toggle for local hooks

[hlissner]

When I invoke M-x helpful-variable on any hook variable with a buffer-local value, helpful displays its buffer-local value, but no "Global Value" button to toggle its global value.

I find changing this line

helpful/helpful.el

Line 2190 in c0662aa

(when (local-variable-if-set-p sym)

To

        (when (local-variable-if-set-p sym helpful--associated-buffer)

fixes the issue for me, but introduces another: once you toggle the global value of a hook, both "Buffer values" and "Global values" buttons disappear. No way to return to the buffer-local value without invoking helpful-variable from scratch.

---

Tested on Emacs 26.3 and 27.0.91 in vanilla and Doom Emacs, with the latest commit of helpful (c0662aa).

[twlz0ne]

I looked at the latest code and if there is a buffer local value, then the "Global value" will never be displayed:

helpful/helpful.el

Lines 2271 to 2282 in 60c1cd4

	((and
	helpful--associated-buffer
	(local-variable-p sym helpful--associated-buffer))
	(format "Value in %s"
	(helpful--button
	(format "#<buffer %s>" (buffer-name helpful--associated-buffer))
	'helpful-buffer-button
	'buffer helpful--associated-buffer
	'position pos)))
	;; Buffer-local variable but default/global value.
	((local-variable-if-set-p sym)
	"Global Value")

@Wilfred Is there any particular reason for this?

Code to reproduce:

(progn
  (defvar foo '(1))
  (put 'foo 'standard-value (list (list 'quote '(2))))
  (setq-local foo '(3))
  (describe-variable 'foo)
  (helpful-variable 'foo))

[haji-ali]

See #311 for a possible fix.