Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgb for watershed #12

Open
cpaniaguam opened this issue Jun 12, 2024 · 1 comment
Open

rgb for watershed #12

cpaniaguam opened this issue Jun 12, 2024 · 1 comment

Comments

@cpaniaguam
Copy link
Member

@ellenbuckley In the watershed computation

#rewatershed
im4 = cv2.watershed(rgb,markers)

the rgb image is used. It is initialized in a block after the cloud mask is created

    red_c = np.copy(tci.read()[0])
    green_c = np.copy(tci.read()[1])
    blue_c = np.copy(tci.read()[2])
    rgb = np.dstack([red_c, green_c, blue_c])

However, a few lines downstream, in a conditional block for saving images, this object is redefined (by applying in turn, cloud/land masks to each layer) and then used in the watershed computation. If save_fig is initially set to False the unmasked rgb image will be used for the watershed. Could you clarify which version of rgb should be used for the watershed, the original or the land+cloud-masked version?

Thanks!

@ellenbuckley
Copy link
Collaborator

ah! good find. can we use the land+cloud-masked version for the watershed please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants