Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning code #142

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Cleaning code #142

merged 2 commits into from
Mar 2, 2023

Conversation

Andresmagic
Copy link
Contributor

@Andresmagic Andresmagic commented Feb 27, 2023

What does this PR do?

Clean-up all the code, erasing all the unnecessary spaces, comments, libraries, variables, etc.

Where should the reviewer start?

Just checking all the files that were modified, and review if there's other things I can delete or something that I shouldn't have deleted. Most of it are spaces, but in other instances there are some variables and libraries eliminated.

Any background context you want to provide?

I thought about this ticket while doing other tickets, I thought it was a good idea to eliminate all the things that aren't being used and don't have unnecessary things on the code:)

Checklist

  • I added the necessary documentation, if appropriate.
  • I added tests to prove that my fix is effective or my feature works.
  • I reviewed existing Pull Requests before submitting mine.

Copy link
Contributor

@martinrobled0 martinrobled0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks to clean that 👍🏽

@martinrobled0 martinrobled0 merged commit 09074e2 into main Mar 2, 2023
@martinrobled0 martinrobled0 deleted the Cleaning-code branch March 2, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleaning code
2 participants