Bug: Something isn't right when selecting all options in Save Changes to Theme

[beafialho]

When I select all the options in Save Changes to theme, this is happening:

The links that have a # are also having an issue with weird text showing up on the front end.

There's also this warning from Theme Check plugin:

WARNING: Found ="<?php esc_html_e in patterns/front-page.php. Use esc_attr_e() inside HTML attributes, and esc_url() for link attributes. A manual review is needed.

Line 36: <figure class='wp-block-image size-full'><img src='<?php echo esc_url( get_stylesheet_directory_uri() ); ?>/assets/images/mood_1-min.jpg' alt='<?php esc_html_e('', 'cottage');?>'/></figure>

[creativecoder]

I think the warning is coming from this: alt='<?php esc_html_e('', 'cottage');?>'.

We need to update the escaping functionality to correctly use esc_attr_e inside html attributes.

This change is part of #683. I think we should extract that part and land it separately.

[mikachan]

I think we should extract that part and land it separately.

I agree, that way we can hopefully fix the bug in this issue separately.

[matiasbenedetto]

I'll split the attr part of #683 to fix this