From 504c0546bfe798dfcad6587f75448b29c5b32ba0 Mon Sep 17 00:00:00 2001 From: Carlos Bravo <37012961+cbravobernal@users.noreply.github.com> Date: Thu, 17 Oct 2024 11:52:35 +0200 Subject: [PATCH 1/2] Target base branch instead of just trunk --- .github/workflows/performance.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index a79f2eee9315a5..e426d530541e18 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -49,7 +49,7 @@ jobs: - name: Compare performance with trunk if: github.event_name == 'pull_request' - run: ./bin/plugin/cli.js perf $GITHUB_SHA trunk --tests-branch $GITHUB_SHA + run: ./bin/plugin/cli.js perf $GITHUB_SHA ${{ github.base_ref }} --tests-branch $GITHUB_SHA - name: Compare performance with current WordPress Core and previous Gutenberg versions if: github.event_name == 'release' From d3e233e5b66b0fa62adb7091380fcf0e9727f7eb Mon Sep 17 00:00:00 2001 From: Carlos Bravo <37012961+cbravobernal@users.noreply.github.com> Date: Thu, 17 Oct 2024 12:14:12 +0200 Subject: [PATCH 2/2] Update description --- .github/workflows/performance.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/performance.yml b/.github/workflows/performance.yml index e426d530541e18..b947f4ff08c602 100644 --- a/.github/workflows/performance.yml +++ b/.github/workflows/performance.yml @@ -47,7 +47,7 @@ jobs: [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh" nvm -v - - name: Compare performance with trunk + - name: Compare performance with base branch if: github.event_name == 'pull_request' run: ./bin/plugin/cli.js perf $GITHUB_SHA ${{ github.base_ref }} --tests-branch $GITHUB_SHA