Skip to content

Commit 8530844

Browse files
committed
Replace close button in other components
1 parent e635a71 commit 8530844

File tree

5 files changed

+36
-27
lines changed

5 files changed

+36
-27
lines changed

frontend/src/components/VBanner/VNotificationBanner.vue

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,16 @@
1313
</p>
1414

1515
<slot name="end">
16-
<VCloseButton
17-
:variant="variant === 'dark' ? 'black' : 'transparent-gray'"
18-
size="close"
19-
icon-size="small"
16+
<VIconButton
17+
:variant="variant === 'dark' ? 'transparent-tx' : 'transparent-gray'"
18+
:icon-props="{ name: 'close-small' }"
19+
size="small"
2020
:label="closeButtonLabel || $t('modal.closeBanner')"
21-
@close="$emit('close')"
21+
:class="{
22+
'focus-slim-tx-yellow hover:bg-white hover:bg-opacity-10':
23+
variant === 'dark',
24+
}"
25+
@click="$emit('close')"
2226
/>
2327
</slot>
2428
</section>
@@ -32,7 +36,7 @@ import { defineEvent } from "~/types/emits"
3236
import type { BannerId } from "~/types/banners"
3337
3438
import VIcon from "~/components/VIcon/VIcon.vue"
35-
import VCloseButton from "~/components/VCloseButton.vue"
39+
import VIconButton from "~/components/VIconButton/VIconButton.vue"
3640
3741
import type { TranslateResult } from "vue-i18n"
3842
@@ -43,8 +47,8 @@ import type { TranslateResult } from "vue-i18n"
4347
export default defineComponent({
4448
name: "VNotificationBanner",
4549
components: {
50+
VIconButton,
4651
VIcon,
47-
VCloseButton,
4852
},
4953
props: {
5054
/**

frontend/src/components/VContentReport/VContentReportPopover.vue

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,13 @@
1111
</template>
1212
<template #default="{ close }">
1313
<div class="grid w-80 items-stretch justify-stretch">
14-
<VCloseButton
14+
<VIconButton
1515
:label="$t('modal.close')"
16-
class="z-10 col-start-1 row-start-1 self-start justify-self-end"
17-
@close="close"
16+
:icon-props="{ name: 'close-small' }"
17+
variant="filled-white"
18+
size="medium"
19+
class="z-10 col-start-1 row-start-1 me-1 mt-1 self-start justify-self-end"
20+
@click="close"
1821
/>
1922
<VContentReportForm
2023
class="col-start-1 row-start-1 p-6"
@@ -32,15 +35,15 @@ import { defineComponent, PropType } from "vue"
3235
3336
import type { AudioDetail, ImageDetail } from "~/types/media"
3437
35-
import VCloseButton from "~/components/VCloseButton.vue"
3638
import VContentReportButton from "~/components/VContentReport/VContentReportButton.vue"
3739
import VContentReportForm from "~/components/VContentReport/VContentReportForm.vue"
3840
import VPopover from "~/components/VPopover/VPopover.vue"
41+
import VIconButton from "~/components/VIconButton/VIconButton.vue"
3942
4043
export default defineComponent({
4144
name: "VContentReportPopover",
4245
components: {
43-
VCloseButton,
46+
VIconButton,
4447
VContentReportButton,
4548
VContentReportForm,
4649
VPopover,

frontend/src/components/VHeader/VHeaderInternal.vue

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,13 @@
5353
<template #top-bar>
5454
<div class="flex h-20 w-full justify-between px-2 py-4">
5555
<VHomeLink variant="light" />
56-
<VCloseButton
57-
variant="black"
58-
icon-size="medium"
56+
<VIconButton
57+
variant="transparent-tx"
58+
size="large"
59+
:icon-props="{ name: 'close' }"
60+
class="text-white focus-slim-tx-yellow hover:bg-white hover:bg-opacity-10"
5961
:label="$t('modal.closePagesMenu')"
60-
@close="closePageMenu"
62+
@click="closePageMenu"
6163
/>
6264
</div>
6365
</template>
@@ -92,7 +94,6 @@ import usePages from "~/composables/use-pages"
9294
9395
import { useUiStore } from "~/stores/ui"
9496
95-
import VCloseButton from "~/components/VCloseButton.vue"
9697
import VHomeLink from "~/components/VHeader/VHomeLink.vue"
9798
import VPageLinks from "~/components/VHeader/VPageLinks.vue"
9899
import VModalContent from "~/components/VModal/VModalContent.vue"
@@ -104,7 +105,6 @@ export default defineComponent({
104105
name: "VHeaderInternal",
105106
components: {
106107
VIconButton,
107-
VCloseButton,
108108
VModalContent,
109109
VPopoverContent,
110110
VHomeLink,

frontend/src/components/VHeader/VHeaderMobile/VContentSettingsModalContent.vue

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@
3535
v-if="showFilters"
3636
:applied-filter-count="appliedFilterCount"
3737
/>
38-
<VCloseButton
38+
<VIconButton
3939
:label="$t('modal.closeContentSettings')"
40+
:icon-props="{ name: 'close-small' }"
4041
variant="filled-white"
42+
size="large"
4143
class="ms-auto self-center"
42-
@close="close"
44+
@click="close"
4345
/>
4446
</template>
4547
<VTabPanel id="content-settings">
@@ -84,8 +86,6 @@ import { useSearchStore } from "~/stores/search"
8486
import useSearchType from "~/composables/use-search-type"
8587
8688
import VButton from "~/components/VButton.vue"
87-
import VCloseButton from "~/components/VCloseButton.vue"
88-
8989
import VFilterTab from "~/components/VHeader/VHeaderMobile/VFilterTab.vue"
9090
import VIcon from "~/components/VIcon/VIcon.vue"
9191
import VModalContent from "~/components/VModal/VModalContent.vue"
@@ -96,14 +96,15 @@ import VTab from "~/components/VTabs/VTab.vue"
9696
import VTabPanel from "~/components/VTabs/VTabPanel.vue"
9797
import VTabs from "~/components/VTabs/VTabs.vue"
9898
import VSafeBrowsing from "~/components/VSafeBrowsing/VSafeBrowsing.vue"
99+
import VIconButton from "~/components/VIconButton/VIconButton.vue"
99100
100101
type ContentSettingsTab = "content-settings" | "filters"
101102
102103
export default defineComponent({
103104
name: "VContentSettingsModalContent",
104105
components: {
106+
VIconButton,
105107
VSafeBrowsing,
106-
VCloseButton,
107108
VIcon,
108109
VModalContent,
109110
VButton,

frontend/src/components/VModal/VModalContent.vue

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,12 @@
3434
class="flex w-full shrink-0 justify-between py-4 pe-3 ps-4 md:justify-end md:bg-tx md:px-0 md:py-3"
3535
:class="[$style[`top-bar-${variant}`], $style[`top-bar-${mode}`]]"
3636
>
37-
<VCloseButton
37+
<VIconButton
3838
ref="closeButton"
3939
:label="$t('modal.ariaClose')"
4040
variant="filled-white"
41-
@close="hide()"
41+
size="small"
42+
@click="hide()"
4243
/>
4344
</div>
4445
</slot>
@@ -66,14 +67,14 @@ import { useDialogContent } from "~/composables/use-dialog-content"
6667
6768
import type { ModalColorMode, ModalVariant } from "~/types/modal"
6869
69-
import VCloseButton from "~/components/VCloseButton.vue"
70+
import VIconButton from "~/components/VIconButton/VIconButton.vue"
7071
7172
/**
7273
* Renders the inner content of a modal and manages focus.
7374
*/
7475
export default defineComponent({
7576
name: "VModalContent",
76-
components: { VCloseButton, VTeleport },
77+
components: { VIconButton, VTeleport },
7778
inheritAttrs: false,
7879
props: {
7980
visible: {

0 commit comments

Comments
 (0)