diff --git a/openverse_catalog/dags/providers/provider_api_scripts/cleveland_museum_of_art.py b/openverse_catalog/dags/providers/provider_api_scripts/cleveland_museum_of_art.py index 05e5af9b51a..df4b7a3d7e3 100644 --- a/openverse_catalog/dags/providers/provider_api_scripts/cleveland_museum_of_art.py +++ b/openverse_catalog/dags/providers/provider_api_scripts/cleveland_museum_of_art.py @@ -56,7 +56,7 @@ def _get_response(query_param, endpoint=ENDPOINT, retries=RETRIES): response_json, total_images, tries = None, 0, 0 for tries in range(retries): response = delay_request.get(endpoint, query_param) - if response.status_code == 200 and response is not None: + if response is not None and response.status_code == 200: try: response_json = response.json() total_images = len(response_json["data"]) diff --git a/tests/dags/providers/provider_api_scripts/test_cleveland_museum_of_art.py b/tests/dags/providers/provider_api_scripts/test_cleveland_museum_of_art.py index 819cd9dd535..0ac690ec78b 100644 --- a/tests/dags/providers/provider_api_scripts/test_cleveland_museum_of_art.py +++ b/tests/dags/providers/provider_api_scripts/test_cleveland_museum_of_art.py @@ -143,6 +143,17 @@ def test_get_response_failure(): assert mock_get.call_count == 3 +def test_get_response_None(): + query_param = {"cc": 1, "has_image": 1, "limit": 1, "skip": -1} + with patch.object(clm.delay_request, "get", return_value=None) as mock_get: + response_json, total_images = clm._get_response(query_param) + + assert response_json is None + assert total_images == 0 + # Retries + assert mock_get.call_count == 3 + + def test_handle_response(): response_json = _get_resource_json("handle_response_data.json") data = response_json["data"]