Fix broken schemathesis tests (#5276)

Author: dhruvkb

api/api/views/media_views.py

@@ -46,6 +46,7 @@ class MediaViewSet(AsyncViewSetMixin, AsyncAPIView, ReadOnlyModelViewSet):
     view_is_async = True
 
     lookup_field = "identifier"
+    lookup_value_converter = "uuid"
 
     pagination_class = StandardPagination
 

api/conf/settings/sentry.py

@@ -4,6 +4,7 @@
 from sentry_sdk.integrations.logging import LoggingIntegration, ignore_logger
 
 from conf.settings.base import ENVIRONMENT
+from conf.settings.security import DEBUG
 
 
 SENTRY_DSN = config("SENTRY_DSN", default="")
@@ -13,9 +14,6 @@
     "SENTRY_PROFILES_SAMPLE_RATE", default=0, cast=float
 )
 
-# SECURITY WARNING: don't run with debug turned on in production!
-DEBUG = config("DJANGO_DEBUG_ENABLED", default=False, cast=bool)
-
 INTEGRATIONS = [
     DjangoIntegration(),
     # This prevents two errors from being sent to Sentry (one with the correct

api/conf/urls/__init__.py

@@ -24,7 +24,7 @@
     path("", include(deprecations_urlpatterns)),  # Deprecated, redirects to new URL
 ]
 
-router = SimpleRouter()
+router = SimpleRouter(use_regex_path=False)
 router.register("audio", AudioViewSet, basename="audio")
 router.register("images", ImageViewSet, basename="image")
 versioned_paths += router.urls

api/test/test_schema.py

@@ -3,11 +3,32 @@
 from django.conf import settings
 
 import schemathesis
+from schemathesis.checks import content_type_conformance
 
 
 schema = schemathesis.from_uri(f"{settings.CANONICAL_ORIGIN}/v1/schema/")
 
 
+def status_code_aware_content_type_conformance(ctx, res, case):
+    """
+    Skip Content-Type conformance check when status code is 404.
+
+    A status code of 404 can come from two sources:
+    - Django sees the incoming URL and cannot map it to any endpoint.
+      This returns an HTML response.
+    - DRF gets the request but cannot map any object to the identifier.
+      This returns a content-negotiated HTML/JSON response.
+
+    Since the end user will likely not be using the data in the 404
+    response anyway, we don't need the Content-Type to be validated.
+    """
+
+    if res.status_code == 404:
+        return
+
+    return content_type_conformance(ctx, res, case)
+
+
 # The null-bytes Bearer tokens are skipped.
 # The pattern identifies tests with headers that are acceptable,
 # by only allowing authorization headers that use characters valid for
@@ -30,4 +51,7 @@ def test_schema(case: schemathesis.Case):
         # from schemathesis's implementation of `parameterize`.
         return
 
-    case.call_and_validate()
+    case.call_and_validate(
+        excluded_checks=[content_type_conformance],
+        additional_checks=[status_code_aware_content_type_conformance],
+    )